Send the value of google_brand::GetBrand in component update checks.

components/update_client/update_checker.cc

Index: components/update_client/update_checker.cc
diff --git a/components/update_client/update_checker.cc b/components/update_client/update_checker.cc
index dd851d9baf0d6ca059936ef4b704ebb0ae341b67..a36e7c6e9fe66ec638cc7b38db2ed8c4fdc0e6de 100644
--- a/components/update_client/update_checker.cc
+++ b/components/update_client/update_checker.cc
@@ -45,12 +45,15 @@ namespace {
 std::string BuildUpdateCheckRequest(const Configurator& config,
                                     const std::vector<CrxUpdateItem*>& items,
                                     const std::string& additional_attributes) {
+  const std::string brand(config.GetBrand());
   std::string app_elements;
   for (size_t i = 0; i != items.size(); ++i) {
     const CrxUpdateItem* item = items[i];
     std::string app("<app ");
     base::StringAppendF(&app, "appid=\"%s\" version=\"%s\"", item->id.c_str(),
                         item->component.version.GetString().c_str());
+    if (!brand.empty())
+      base::StringAppendF(&app, " brand=\"%s\"", brand.c_str());

[waffles, 2016/03/22 23:01:34]

Can we sanitize brand (to "^([a-zA-Z]{4})?$") before appending it like this?
IIUC, there isn't any sanitization in google_brand::GetBrand.

[Sorin Jianu, 2016/03/23 02:10:32]

Done.

     if (item->on_demand)
       base::StringAppendF(&app, " installsource=\"ondemand\"");
     base::StringAppendF(&app, ">");