Issue 1823263002: Add graph intrinsics for many math library functions:

Issue 1823263002: Add graph intrinsics for many math library functions: (Closed)

Created:
4 years, 9 months ago by Cutch

Modified:
4 years, 9 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add graph intrinsics for many math library functions: - sin, cos, tan, asin, acos, atan, and atan2. Other fixes: - support calling from intrinsic code R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/0a8c668e5c012ab0706b6a42eb54ab4160810ed1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+292 lines, -27 lines)			Patch
M	runtime/vm/constants_arm.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/constants_ia32.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/constants_mips.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/constants_x64.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier.cc	View		13 chunks	+201 lines, -16 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/method_recognizer.h	View		3 chunks	+9 lines, -7 lines	0 comments	Download

Total messages: 7 (3 generated)

Florian Schneider

Lgtm. We should make sure to have assertions in the register allocator in place because ...

4 years, 9 months ago (2016-03-22 22:19:07 UTC) #4

Cutch

On 2016/03/22 22:19:07, Florian Schneider wrote: > Lgtm. > > We should make sure to ...

4 years, 9 months ago (2016-03-23 13:57:59 UTC) #5

Cutch

4 years, 9 months ago (2016-03-23 13:58:18 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
0a8c668e5c012ab0706b6a42eb54ab4160810ed1 (presubmit successful).