Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Issue 1823183002: Run Sizes on Windows perf builders (take 2) (Closed)

Created:
4 years, 9 months ago by hans
Modified:
4 years, 9 months ago
Reviewers:
dtu, agable, prasadv, qyearsley
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Run Sizes on Windows perf builders (take 2) (The first version of this patch was at https://codereview.chromium.org/1809783003/) This is the same version as the first patch, but without passing --annotate=graphing when running Sizes without a perf_id, as that apparently leads to failure (see crbug.com/596145). BUG=457078 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+733 lines, -30 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_perf.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxUBSanVptr.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dll_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_Builder.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_x64_Builder.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Clang_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_8_perf_bisect.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_fyi_perf_bisect.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_perf_bisect.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_perf_bisect_builder.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_x64_perf_bisect.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_10_perf_bisect.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_10_perf_cq.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_bisect_builder.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_zen_perf_bisect.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64ati_perf_bisect.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64intel_perf_bisect.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64nvidia_perf_bisect.json View 2 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_mips_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_x86_builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/local_test.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
hans
agable: Thanks for figuring out what was happening in crbug.com/596145 This removes the --annotate=graphic flag ...
4 years, 9 months ago (2016-03-22 17:52:34 UTC) #3
agable
This makes sense to me. LGTM.
4 years, 9 months ago (2016-03-22 18:02:09 UTC) #4
hans
On 2016/03/22 18:02:09, agable wrote: > This makes sense to me. LGTM. Thanks! +dtu, +prasadv: ...
4 years, 9 months ago (2016-03-22 18:05:11 UTC) #6
dtu
lgtm
4 years, 9 months ago (2016-03-22 23:46:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823183002/1
4 years, 9 months ago (2016-03-22 23:56:37 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 00:00:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299431

Powered by Google App Engine
This is Rietveld 408576698