Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by agrieve Modified:
4 years, 9 months ago Reviewers:
jbudorick CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionlint.py - print original exception for empty results.xml
BUG=583661
Committed: https://crrev.com/ffd77282c9d5152af0d5fd09cf1a9d39221f0e62
Cr-Commit-Position: refs/heads/master@{#382848}
Patch Set 1 #
Total comments: 2
Patch Set 2 : always return #Patch Set 3 : fix new lint error in chrome/test/chromedriver/test/webview_shell #Patch Set 4 : manifest too #Patch Set 5 : whoops, wrong cl! #Patch Set 6 : rebase #
Created: 4 years, 9 months ago
Depends on Patchset: Messages
Total messages: 17 (9 generated)
Description was changed from ========== lint.py - print original exception for empty results.xml BUG=583661 ========== to ========== lint.py - print original exception for empty results.xml BUG=583661 ==========
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org
https://codereview.chromium.org/1823173002/diff/1/build/android/gyp/lint.py File build/android/gyp/lint.py (right): https://codereview.chromium.org/1823173002/diff/1/build/android/gyp/lint.py#n... build/android/gyp/lint.py:149: return I don't think this should be in the elif.
https://codereview.chromium.org/1823173002/diff/1/build/android/gyp/lint.py File build/android/gyp/lint.py (right): https://codereview.chromium.org/1823173002/diff/1/build/android/gyp/lint.py#n... build/android/gyp/lint.py:149: return On 2016/03/22 23:46:12, jbudorick wrote: > I don't think this should be in the elif. Done.
lgtm
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/1823173002/#ps80001 (title: "whoops, wrong cl!")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823173002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823173002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/1823173002/#ps100001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823173002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823173002/100001
Message was sent while issue was closed.
Description was changed from ========== lint.py - print original exception for empty results.xml BUG=583661 ========== to ========== lint.py - print original exception for empty results.xml BUG=583661 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== lint.py - print original exception for empty results.xml BUG=583661 ========== to ========== lint.py - print original exception for empty results.xml BUG=583661 Committed: https://crrev.com/ffd77282c9d5152af0d5fd09cf1a9d39221f0e62 Cr-Commit-Position: refs/heads/master@{#382848} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/ffd77282c9d5152af0d5fd09cf1a9d39221f0e62 Cr-Commit-Position: refs/heads/master@{#382848} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
