Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1823173002: 🌇 lint.py - print original exception for empty results.xml (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

lint.py - print original exception for empty results.xml BUG=583661 Committed: https://crrev.com/ffd77282c9d5152af0d5fd09cf1a9d39221f0e62 Cr-Commit-Position: refs/heads/master@{#382848}

Patch Set 1 #

Total comments: 2

Patch Set 2 : always return #

Patch Set 3 : fix new lint error in chrome/test/chromedriver/test/webview_shell #

Patch Set 4 : manifest too #

Patch Set 5 : whoops, wrong cl! #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -31 lines) Patch
M build/android/gyp/lint.py View 1 2 3 4 5 1 chunk +48 lines, -31 lines 0 comments Download

Depends on Patchset:

Issue 1543003005 Patch 1

Messages

Total messages: 17 (9 generated)
jbudorick
https://codereview.chromium.org/1823173002/diff/1/build/android/gyp/lint.py File build/android/gyp/lint.py (right): https://codereview.chromium.org/1823173002/diff/1/build/android/gyp/lint.py#newcode149 build/android/gyp/lint.py:149: return I don't think this should be in the ...
4 years, 9 months ago (2016-03-22 23:46:12 UTC) #3
agrieve
https://codereview.chromium.org/1823173002/diff/1/build/android/gyp/lint.py File build/android/gyp/lint.py (right): https://codereview.chromium.org/1823173002/diff/1/build/android/gyp/lint.py#newcode149 build/android/gyp/lint.py:149: return On 2016/03/22 23:46:12, jbudorick wrote: > I don't ...
4 years, 9 months ago (2016-03-23 00:03:07 UTC) #4
jbudorick
lgtm
4 years, 9 months ago (2016-03-23 00:03:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823173002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823173002/80001
4 years, 9 months ago (2016-03-23 01:56:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/8055) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-23 01:58:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823173002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823173002/100001
4 years, 9 months ago (2016-03-23 14:04:12 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-23 15:17:28 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 15:19:12 UTC) #17
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/ffd77282c9d5152af0d5fd09cf1a9d39221f0e62
Cr-Commit-Position: refs/heads/master@{#382848}

Powered by Google App Engine
This is Rietveld 408576698