Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1823153002: Move the fpdfsdk/include/pdfwindow/ headers into fpdfsdk/pdfwindow. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move the fpdfsdk/include/pdfwindow/ headers into fpdfsdk/pdfwindow. This CL moves all of the pdfwindow headers to live beside their source files. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/89e904b1748114df561ebcb020492d085149664e

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -2791 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_checkbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_pushbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_radiobutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_sysfontinfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_Button.h View 1 chunk +0 lines, -27 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_Caret.h View 1 chunk +0 lines, -53 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 1 chunk +0 lines, -106 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 2 3 1 chunk +0 lines, -172 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 1 2 3 1 chunk +0 lines, -181 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_FontMap.h View 1 chunk +0 lines, -137 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_Icon.h View 1 2 3 1 chunk +0 lines, -58 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_IconList.h View 1 2 3 1 chunk +0 lines, -129 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_Label.h View 1 chunk +0 lines, -45 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_ListBox.h View 1 chunk +0 lines, -122 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_ListCtrl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_Note.h View 1 chunk +0 lines, -351 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_ScrollBar.h View 1 chunk +0 lines, -157 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_Signature.h View 1 chunk +0 lines, -67 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_SpecialButton.h View 1 chunk +0 lines, -56 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_Utils.h View 1 chunk +0 lines, -412 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 2 3 1 chunk +0 lines, -472 lines 0 comments Download
M fpdfsdk/javascript/Field.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/color.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + fpdfsdk/pdfwindow/PWL_Button.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Button.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_Caret.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Caret.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_ComboBox.h View 2 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_Edit.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_EditCtrl.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_FontMap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_Icon.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_IconList.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_IconList.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_Label.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Label.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_ListBox.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_ListCtrl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListCtrl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_Note.h View 2 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Note.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_ScrollBar.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_Signature.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Signature.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_SpecialButton.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_SpecialButton.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_Utils.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/pdfwindow/PWL_Wnd.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M pdfium.gyp View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-22 16:54:25 UTC) #2
Tom Sepez
On 2016/03/22 16:54:25, dsinclair wrote: > PTAL. BUILD.gn / pdfium.gyp changes?
4 years, 9 months ago (2016-03-22 17:46:02 UTC) #3
dsinclair
On 2016/03/22 17:46:02, Tom Sepez wrote: > On 2016/03/22 16:54:25, dsinclair wrote: > > PTAL. ...
4 years, 9 months ago (2016-03-22 23:41:55 UTC) #4
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-23 21:33:18 UTC) #5
dsinclair
4 years, 9 months ago (2016-03-23 23:29:07 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
89e904b1748114df561ebcb020492d085149664e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698