Ensure fullscreen.css loaded for ancestor invalidation

Ensure fullscreen.css loaded for ancestor invalidation

Using invalidation sets caused regression crbug.com/596803 because we
only ensured the fullscreen.css had features available for style
resolving in the fullscreened element's document. This CL ensures the
features are up-to-date for all fullscreen related pseudoStateChanged.

I was not able to reproduce the problem in 596803, but 448721 also
regressed and I've confirmed this CL fixes that regression.

The added layout test does not fail without this fix because the
full screen implementation in content_shell is different and
setMediaType() for fullscreen on resize causes a full recalc of
everything in content_shell before we try to apply fullscreen style
changes. However, if mediaQueryAffectingValueChanged was smarter when
changing media type to fullscreen. That test would have failed.

BUG=596803
Committed: https://crrev.com/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65
Cr-Commit-Position: refs/heads/master@{#383711}

[rune, 2016-03-22 16:03:12]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 16:03:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823143002/1

[commit-bot: I haz the power, 2016-03-22 17:16:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 17:16:07]

Dry run: This issue passed the CQ dry run.

[rune, 2016-03-22 18:46:04]

rune@opera.com changed reviewers:
+ esprehn@chromium.org

[rune, 2016-03-22 18:46:04]

Sadly, there's still something left relying on full recalc for fullscreen.

[rune, 2016-03-23 11:38:13]

On 2016/03/22 18:46:04, rune wrote:
> Sadly, there's still something left relying on full recalc for fullscreen.

I found out why, I think. It's missing ensuring UA stylesheet for outer frames
and :-webkit-fullscreen-ancestor. Will fix ...

[rune, 2016-03-23 14:11:24]

Description was changed from

==========
Revert back to using full document recalc for fullscreen.

Using invalidation sets caused regression crbug.com/596803
I have not investigated why yet. I was not able to reproduce the
problem in 596803, but 448721 also regressed and I've confirmed this CL
fixes that regression.

I've also moved the UA stylesheet loading before
setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries, since
that needs the :-webkit-fullscreen-ancestor rules, but that wasn't the
reason for the regression. I've not reverted the lazy-loading of
fullscreen.css as we don't want to check that for every element.

BUG=596803
==========

to

==========
Ensure fullscreen.css loaded for ancestor invalidation

Using invalidation sets caused regression crbug.com/596803 because we
only ensured the fullscreen.css had features available for style
resolving in the fullscreened element's document. This CL ensures the
features are up-to-date for all fullscreen related pseudoStateChanged.

I was not able to reproduce the problem in 596803, but 448721 also
regressed and I've confirmed this CL fixes that regression.

The added layout test does not fail without this fix because the
full screen implementation in content_shell is different and
setMediaType() for fullscreen on resize causes a full recalc of
everything in content_shell before we try to apply fullscreen style
changes. However, if mediaQueryAffectingValueChanged was smarter when
changing media type to fullscreen. That test would have failed.

BUG=596803
==========

[rune, 2016-03-23 14:11:35]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 14:11:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823143002/20001

[rune, 2016-03-23 14:12:53]

On 2016/03/23 11:38:13, rune wrote:
> On 2016/03/22 18:46:04, rune wrote:
> > Sadly, there's still something left relying on full recalc for fullscreen.
> 
> I found out why, I think. It's missing ensuring UA stylesheet for outer frames
> and :-webkit-fullscreen-ancestor. Will fix ...

New patch up.

[commit-bot: I haz the power, 2016-03-23 16:27:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 16:27:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2016-03-28 12:16:54]

ping

[philipj_slow, 2016-03-29 12:17:37]

philipj@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2016-03-29 12:17:37]

LGTM, fix and test makes sense to me. esprehn@, if you were meaning to review
this and just didn't get around to it, please don't hesitate to do so still.

https://codereview.chromium.org/1823143002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html
(right):

https://codereview.chromium.org/1823143002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html:4:
<iframe allowfullscreen id="frame" src="data:text/html,<video></video>"
onload="runTest()"></iframe>
I think that in principle it's possible that the iframe loads before the parser
of this document gets to the script tag below. I'm sure it won't happen for
file://, but change order anyway?

[rune, 2016-03-29 12:41:34]

https://codereview.chromium.org/1823143002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html
(right):

https://codereview.chromium.org/1823143002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html:4:
<iframe allowfullscreen id="frame" src="data:text/html,<video></video>"
onload="runTest()"></iframe>
On 2016/03/29 12:17:37, philipj_UTC7 wrote:
> I think that in principle it's possible that the iframe loads before the
parser
> of this document gets to the script tag below. I'm sure it won't happen for
> file://, but change order anyway?

Done.

[rune, 2016-03-29 12:41:59]

The CQ bit was checked by rune@opera.com

[rune, 2016-03-29 12:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1823143002/#ps40001
(title: "Re-ordered iframe and script in test")

[commit-bot: I haz the power, 2016-03-29 12:42:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823143002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823143002/40001

[commit-bot: I haz the power, 2016-03-29 13:41:52]

Description was changed from

==========
Ensure fullscreen.css loaded for ancestor invalidation

Using invalidation sets caused regression crbug.com/596803 because we
only ensured the fullscreen.css had features available for style
resolving in the fullscreened element's document. This CL ensures the
features are up-to-date for all fullscreen related pseudoStateChanged.

I was not able to reproduce the problem in 596803, but 448721 also
regressed and I've confirmed this CL fixes that regression.

The added layout test does not fail without this fix because the
full screen implementation in content_shell is different and
setMediaType() for fullscreen on resize causes a full recalc of
everything in content_shell before we try to apply fullscreen style
changes. However, if mediaQueryAffectingValueChanged was smarter when
changing media type to fullscreen. That test would have failed.

BUG=596803
==========

to

==========
Ensure fullscreen.css loaded for ancestor invalidation

Using invalidation sets caused regression crbug.com/596803 because we
only ensured the fullscreen.css had features available for style
resolving in the fullscreened element's document. This CL ensures the
features are up-to-date for all fullscreen related pseudoStateChanged.

I was not able to reproduce the problem in 596803, but 448721 also
regressed and I've confirmed this CL fixes that regression.

The added layout test does not fail without this fix because the
full screen implementation in content_shell is different and
setMediaType() for fullscreen on resize causes a full recalc of
everything in content_shell before we try to apply fullscreen style
changes. However, if mediaQueryAffectingValueChanged was smarter when
changing media type to fullscreen. That test would have failed.

BUG=596803
==========

[commit-bot: I haz the power, 2016-03-29 13:41:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-29 13:43:26]

Description was changed from

==========
Ensure fullscreen.css loaded for ancestor invalidation

Using invalidation sets caused regression crbug.com/596803 because we
only ensured the fullscreen.css had features available for style
resolving in the fullscreened element's document. This CL ensures the
features are up-to-date for all fullscreen related pseudoStateChanged.

I was not able to reproduce the problem in 596803, but 448721 also
regressed and I've confirmed this CL fixes that regression.

The added layout test does not fail without this fix because the
full screen implementation in content_shell is different and
setMediaType() for fullscreen on resize causes a full recalc of
everything in content_shell before we try to apply fullscreen style
changes. However, if mediaQueryAffectingValueChanged was smarter when
changing media type to fullscreen. That test would have failed.

BUG=596803
==========

to

==========
Ensure fullscreen.css loaded for ancestor invalidation

Using invalidation sets caused regression crbug.com/596803 because we
only ensured the fullscreen.css had features available for style
resolving in the fullscreened element's document. This CL ensures the
features are up-to-date for all fullscreen related pseudoStateChanged.

I was not able to reproduce the problem in 596803, but 448721 also
regressed and I've confirmed this CL fixes that regression.

The added layout test does not fail without this fix because the
full screen implementation in content_shell is different and
setMediaType() for fullscreen on resize causes a full recalc of
everything in content_shell before we try to apply fullscreen style
changes. However, if mediaQueryAffectingValueChanged was smarter when
changing media type to fullscreen. That test would have failed.

BUG=596803

Committed: https://crrev.com/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65
Cr-Commit-Position: refs/heads/master@{#383711}
==========

[commit-bot: I haz the power, 2016-03-29 13:43:28]

Patchset 3 (id:??) landed as
https://crrev.com/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65
Cr-Commit-Position: refs/heads/master@{#383711}