Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1823143002: Ensure fullscreen.css loaded for ancestor invalidation (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 8 months ago
Reviewers:
esprehn, philipj_slow
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure fullscreen.css loaded for ancestor invalidation Using invalidation sets caused regression crbug.com/596803 because we only ensured the fullscreen.css had features available for style resolving in the fullscreened element's document. This CL ensures the features are up-to-date for all fullscreen related pseudoStateChanged. I was not able to reproduce the problem in 596803, but 448721 also regressed and I've confirmed this CL fixes that regression. The added layout test does not fail without this fix because the full screen implementation in content_shell is different and setMediaType() for fullscreen on resize causes a full recalc of everything in content_shell before we try to apply fullscreen style changes. However, if mediaQueryAffectingValueChanged was smarter when changing media type to fullscreen. That test would have failed. BUG=596803 Committed: https://crrev.com/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65 Cr-Commit-Position: refs/heads/master@{#383711}

Patch Set 1 #

Patch Set 2 : Ensure fullscreen.css loaded for all fullscreen pseudoStateChanged #

Total comments: 2

Patch Set 3 : Re-ordered iframe and script in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823143002/1
4 years, 9 months ago (2016-03-22 16:03:24 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 17:16:07 UTC) #4
rune
Sadly, there's still something left relying on full recalc for fullscreen.
4 years, 9 months ago (2016-03-22 18:46:04 UTC) #6
rune
On 2016/03/22 18:46:04, rune wrote: > Sadly, there's still something left relying on full recalc ...
4 years, 9 months ago (2016-03-23 11:38:13 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823143002/20001
4 years, 9 months ago (2016-03-23 14:11:50 UTC) #10
rune
On 2016/03/23 11:38:13, rune wrote: > On 2016/03/22 18:46:04, rune wrote: > > Sadly, there's ...
4 years, 9 months ago (2016-03-23 14:12:53 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/200889)
4 years, 9 months ago (2016-03-23 16:27:05 UTC) #13
rune
ping
4 years, 8 months ago (2016-03-28 12:16:54 UTC) #14
philipj_slow
LGTM, fix and test makes sense to me. esprehn@, if you were meaning to review ...
4 years, 8 months ago (2016-03-29 12:17:37 UTC) #16
rune
https://codereview.chromium.org/1823143002/diff/20001/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html File third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html (right): https://codereview.chromium.org/1823143002/diff/20001/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html#newcode4 third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html:4: <iframe allowfullscreen id="frame" src="data:text/html,<video></video>" onload="runTest()"></iframe> On 2016/03/29 12:17:37, philipj_UTC7 ...
4 years, 8 months ago (2016-03-29 12:41:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823143002/40001
4 years, 8 months ago (2016-03-29 12:42:11 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 13:41:54 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 13:43:28 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65
Cr-Commit-Position: refs/heads/master@{#383711}

Powered by Google App Engine
This is Rietveld 408576698