third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp - Issue 1823133002: Use sk_sp-based picture recording APIs in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

Issue 1823133002: Use sk_sp-based picture recording APIs in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp ('k') | third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

index e859f802d90c81e4ed37c0b07cb0943fff9ecb6e..4ca1bfe1244a02fa0151e79d2cdba1c38c1cd734 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

@@ -9,6 +9,7 @@

#include "platform/graphics/paint/DrawingDisplayItem.h"

#include "platform/graphics/paint/SubsequenceDisplayItem.h"

#include "platform/graphics/paint/TransformDisplayItem.h"

+#include "platform/graphics/skia/SkiaUtils.h"

#include "platform/transforms/AffineTransform.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -47,7 +48,7 @@ static PassRefPtr<SkPicture> createRectPicture(const IntRect& bounds)

SkCanvas* canvas = recorder.beginRecording(bounds.width(), bounds.height());

canvas->drawRect(SkRect::MakeXYWH(bounds.x(), bounds.y(), bounds.width(), bounds.height()),

SkPaint());

- return adoptRef(recorder.endRecordingAsPicture());

+ return fromSkSp(recorder.finishRecordingAsPicture());

}

TEST_F(DisplayItemListTest, AppendVisualRect_Simple)