Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 182313014: Omnibox: Launch URL Demotion in the Fakebox by Default (Closed)

Created:
6 years, 9 months ago by Mark P
Modified:
6 years, 9 months ago
Reviewers:
H Fung, Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Omnibox: Launch URL Demotion in the Fakebox by Default This has been approved for launch. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/omnibox/omnibox_field_trial.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mark P
Please take a look, thanks.
6 years, 9 months ago (2014-02-27 22:36:59 UTC) #1
Peter Kasting
LGTM; does "approved for launch" mean "we saw positive results from our trials"? I'm curious ...
6 years, 9 months ago (2014-02-27 22:38:27 UTC) #2
Mark P
On 2014/02/27 22:38:27, Peter Kasting wrote: > LGTM; does "approved for launch" mean "we saw ...
6 years, 9 months ago (2014-02-27 23:02:55 UTC) #3
H Fung
Thanks, but I'm not sure if you want the server-side change (to prevent queries from ...
6 years, 9 months ago (2014-02-27 23:38:38 UTC) #4
Mark P
On 2014/02/27 23:38:38, H Fung wrote: > Thanks, but I'm not sure if you want ...
6 years, 9 months ago (2014-02-27 23:43:44 UTC) #5
H Fung
On 2014/02/27 23:43:44, Mark P wrote: > On 2014/02/27 23:38:38, H Fung wrote: > > ...
6 years, 9 months ago (2014-03-03 19:41:35 UTC) #6
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 9 months ago (2014-03-06 23:34:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/182313014/1
6 years, 9 months ago (2014-03-06 23:45:01 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 13:45:53 UTC) #9
Message was sent while issue was closed.
Change committed as 255606

Powered by Google App Engine
This is Rietveld 408576698