Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/extensions.gyp

Issue 182313002: Include sync.pb.h in sync_data.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/chrome_tests.gypi ('K') | « chrome/chrome_tests.gypi ('k') | sync/api/sync_data.h » ('j') | sync/api/sync_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/extensions.gyp
diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp
index 1045e535d1a004c41303ce4b52040f7f33fff956..2dd6daf039525631de7d5a21dea4bf984f016512 100644
--- a/extensions/extensions.gyp
+++ b/extensions/extensions.gyp
@@ -155,6 +155,11 @@
'../chrome/common/extensions/api/api.gyp:api',
'../content/content.gyp:content_browser',
'../skia/skia.gyp:skia',
+ # Declaring a dependency on sync because extensions_browser depends on
+ # browser_extensions, which depends on sync. We cannot simply declare a
+ # dependency on browser_extensions because that would create a cycle
+ # (browser_extension already depends on extensions_browser).
Nico 2014/03/07 19:13:00 Same question as above.
maniscalco 2014/03/07 23:44:37 No longer needed!
+ '../sync/sync.gyp:sync',
],
'include_dirs': [
'..',
« chrome/chrome_tests.gypi ('K') | « chrome/chrome_tests.gypi ('k') | sync/api/sync_data.h » ('j') | sync/api/sync_data.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698