Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: chrome/chrome.gyp

Issue 182313002: Include sync.pb.h in sync_data.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_browser_extensions.gypi » ('j') | chrome/chrome_browser_extensions.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index f4c319966dda7e1cce94ffdfa04dfaa25f3416dd..3e80793e27dbb59e3a8e91da73a6eb579f6fd532 100644
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -143,6 +143,11 @@
'../net/net.gyp:http_server',
'../net/net.gyp:net',
'../skia/skia.gyp:skia',
+ # Declaring a dependency on sync because debugger depends on
+ # browser, which depends on sync. We cannot simply declare a
Nico 2014/03/07 19:13:00 In what way does debugger depend on browser? Does
maniscalco 2014/03/07 23:44:37 Good question. I've removed/replaced some #includ
+ # dependency on browser because that would create a cycle (browser
+ # already depends on debugger).
+ '../sync/sync.gyp:sync',
'../third_party/icu/icu.gyp:icui18n',
'../third_party/icu/icu.gyp:icuuc',
'../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
« no previous file with comments | « no previous file | chrome/chrome_browser_extensions.gypi » ('j') | chrome/chrome_browser_extensions.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698