Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1823103002: PPC: Introduce a code stub version of Array.prototype.push (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Introduce a code stub version of Array.prototype.push Port 1134688cedecfdc35808d48fbdfeda49450cb618 Original commit message: This roughly doubles performance for generic Array.prototype.push. R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/f0d88f9084729a7b0600b35b117fc1e48307e8d3 Cr-Commit-Position: refs/heads/master@{#34999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-22 15:28:27 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823103002/1
4 years, 9 months ago (2016-03-22 15:28:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 16:14:04 UTC) #5
JoranSiu
On 2016/03/22 16:14:04, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 9 months ago (2016-03-22 16:53:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823103002/1
4 years, 9 months ago (2016-03-22 16:55:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 16:57:15 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 16:57:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0d88f9084729a7b0600b35b117fc1e48307e8d3
Cr-Commit-Position: refs/heads/master@{#34999}

Powered by Google App Engine
This is Rietveld 408576698