Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: base/sequence_checker.h

Issue 18231002: base: Change WeakPtr to use SequenceChecker instead of ThreadChecker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/sequence_checker.h
diff --git a/base/sequence_checker.h b/base/sequence_checker.h
index fbf146ac502d3efd7dd26667cae291cbe501344f..c98875b8f813b37ffb5b2d02000a97c8a93d1667 100644
--- a/base/sequence_checker.h
+++ b/base/sequence_checker.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2013 The Chromium Authors. All rights reserved.
vandebo (ex-Chrome) 2013/06/28 21:00:06 nit: current policy is to not update copyright not
tommycli 2013/06/28 22:37:07 Done.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -31,9 +31,6 @@ class SequenceCheckerDoNothing {
bool CalledOnValidSequence() const {
return true;
}
-
- void ChangeSequence(
- const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) {}
};
vandebo (ex-Chrome) 2013/06/28 21:00:06 DetachFromSequence() missing?
tommycli 2013/06/28 22:37:07 Done.
// SequenceChecker is a helper class used to help verify that some
@@ -44,10 +41,6 @@ class SequenceCheckerDoNothing {
// Example:
// class MyClass {
// public:
-// explicit MyClass(
-// const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner)
-// : sequence_checker_(sequenced_task_runner) {}
-//
// void Foo() {
// DCHECK(sequence_checker_.CalledOnValidSequence());
// ... (do stuff) ...
@@ -60,16 +53,9 @@ class SequenceCheckerDoNothing {
// In Release mode, CalledOnValidSequence will always return true.
#if ENABLE_SEQUENCE_CHECKER
class SequenceChecker : public SequenceCheckerImpl {
- public:
- explicit SequenceChecker(
- const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner)
- : SequenceCheckerImpl(sequenced_task_runner) {}
};
#else
class SequenceChecker : public SequenceCheckerDoNothing {
- public:
- explicit SequenceChecker(
- const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) {}
};
#endif // ENABLE_SEQUENCE_CHECKER

Powered by Google App Engine
This is Rietveld 408576698