Chromium Code Reviews| Index: base/sequence_checker_impl.cc |
| diff --git a/base/sequence_checker_impl.cc b/base/sequence_checker_impl.cc |
| index 24d9ed99a147c7c5a8d2db69557b3f891851cfa4..409a3f67c498ea21225a1ad42e2835f0f7787192 100644 |
| --- a/base/sequence_checker_impl.cc |
| +++ b/base/sequence_checker_impl.cc |
| @@ -4,28 +4,53 @@ |
| #include "base/sequence_checker_impl.h" |
| -#include "base/sequenced_task_runner.h" |
| +#include "base/logging.h" |
| namespace base { |
| -SequenceCheckerImpl::SequenceCheckerImpl( |
| - const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) |
| - : sequenced_task_runner_(sequenced_task_runner) {} |
| +SequenceCheckerImpl::SequenceCheckerImpl() |
| + : sequence_token_assigned_(false), |
| + pool_(NULL) { |
| + EnsureSequenceTokenAssigned(); |
| +} |
| SequenceCheckerImpl::~SequenceCheckerImpl() {} |
| bool SequenceCheckerImpl::CalledOnValidSequence() const { |
| + EnsureSequenceTokenAssigned(); |
| AutoLock auto_lock(lock_); |
| - return sequenced_task_runner_.get() ? |
| - sequenced_task_runner_->RunsTasksOnCurrentThread() : |
| - thread_checker_.CalledOnValidThread(); |
| + |
| + if (!pool_) |
|
darin (slow to review)
2013/07/02 13:54:23
this probably deserves a comment to draw attention
tommycli
2013/07/02 17:22:58
Done.
|
| + return thread_checker_.CalledOnValidThread(); |
| + |
| + if (SequencedWorkerPool::Owner() != pool_) |
| + return false; |
| + |
| + return pool_->IsRunningSequenceOnCurrentThread(sequence_token_); |
| } |
| -void SequenceCheckerImpl::ChangeSequence( |
| - const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) { |
| +void SequenceCheckerImpl::DetachFromSequence() { |
| AutoLock auto_lock(lock_); |
| - sequenced_task_runner_ = sequenced_task_runner; |
| thread_checker_.DetachFromThread(); |
| + sequence_token_assigned_ = false; |
| + pool_ = NULL; |
| + sequence_token_ = SequencedWorkerPool::SequenceToken(); |
| +} |
| + |
| +void SequenceCheckerImpl::EnsureSequenceTokenAssigned() const { |
| + AutoLock auto_lock(lock_); |
| + if (sequence_token_assigned_) |
| + return; |
| + |
| + sequence_token_assigned_ = true; |
| + pool_ = SequencedWorkerPool::Owner(); |
| + |
| + // If can't get sequence token, lock to the thread ID. |
| + if (!pool_) |
| + return; |
| + |
| + bool got_token = pool_->GetCurrentThreadSequenceToken(&sequence_token_); |
| + DCHECK(got_token); |
| } |
| } // namespace base |