Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: base/sequence_checker_impl.cc

Issue 18231002: base: Change WeakPtr to use SequenceChecker instead of ThreadChecker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/sequence_checker_impl.h" 5 #include "base/sequence_checker_impl.h"
6 6
7 #include "base/sequenced_task_runner.h"
8
9 namespace base { 7 namespace base {
10 8
11 SequenceCheckerImpl::SequenceCheckerImpl( 9 SequenceCheckerImpl::SequenceCheckerImpl()
12 const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) 10 : sequence_token_assigned_(false),
13 : sequenced_task_runner_(sequenced_task_runner) {} 11 associated_pool_(NULL) {
12 EnsureSequenceTokenAssigned();
13 }
14 14
15 SequenceCheckerImpl::~SequenceCheckerImpl() {} 15 SequenceCheckerImpl::~SequenceCheckerImpl() {}
16 16
17 bool SequenceCheckerImpl::CalledOnValidSequence() const { 17 bool SequenceCheckerImpl::CalledOnValidSequence() const {
18 EnsureSequenceTokenAssigned();
18 AutoLock auto_lock(lock_); 19 AutoLock auto_lock(lock_);
19 return sequenced_task_runner_.get() ? 20
20 sequenced_task_runner_->RunsTasksOnCurrentThread() : 21 if (!associated_pool_)
21 thread_checker_.CalledOnValidThread(); 22 return thread_checker_.CalledOnValidThread();
23
24 if (SequencedWorkerPool::Get() != associated_pool_)
25 return false;
26
27 return associated_pool_->IsRunningSequenceOnCurrentThread(sequence_token_);
22 } 28 }
23 29
24 void SequenceCheckerImpl::ChangeSequence( 30 void SequenceCheckerImpl::DetachFromSequence() {
25 const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) {
26 AutoLock auto_lock(lock_); 31 AutoLock auto_lock(lock_);
27 sequenced_task_runner_ = sequenced_task_runner;
28 thread_checker_.DetachFromThread(); 32 thread_checker_.DetachFromThread();
33 sequence_token_assigned_ = false;
34 associated_pool_ = NULL;
35 sequence_token_ = SequencedWorkerPool::SequenceToken();
36 }
37
38 void SequenceCheckerImpl::EnsureSequenceTokenAssigned() const {
39 AutoLock auto_lock(lock_);
40 if (sequence_token_assigned_)
41 return;
42
43 sequence_token_assigned_ = true;
44 associated_pool_ = SequencedWorkerPool::Get();
45
46 // If can't get sequence token, lock to the thread ID.
vandebo (ex-Chrome) 2013/06/28 21:00:06 If you got a pool, probably should DCHECK that you
tommycli 2013/06/28 22:37:07 Done.
47 if (!associated_pool_ ||
48 !associated_pool_->GetCurrentThreadSequenceToken(&sequence_token_))
49 associated_pool_ = NULL;
29 } 50 }
30 51
31 } // namespace base 52 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698