Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: base/sequence_checker_impl.cc

Issue 18231002: base: Change WeakPtr to use SequenceChecker instead of ThreadChecker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a typo. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/sequence_checker_impl.h" 5 #include "base/sequence_checker_impl.h"
6 6
7 #include "base/sequenced_task_runner.h" 7 #include "base/logging.h"
8 8
9 namespace base { 9 namespace base {
10 10
11 SequenceCheckerImpl::SequenceCheckerImpl( 11 SequenceCheckerImpl::SequenceCheckerImpl()
12 const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) 12 : sequence_token_assigned_(false),
13 : sequenced_task_runner_(sequenced_task_runner) {} 13 pool_(NULL) {
14 EnsureSequenceTokenAssigned();
15 }
14 16
15 SequenceCheckerImpl::~SequenceCheckerImpl() {} 17 SequenceCheckerImpl::~SequenceCheckerImpl() {}
16 18
17 bool SequenceCheckerImpl::CalledOnValidSequence() const { 19 bool SequenceCheckerImpl::CalledOnValidSequence() const {
20 EnsureSequenceTokenAssigned();
18 AutoLock auto_lock(lock_); 21 AutoLock auto_lock(lock_);
19 return sequenced_task_runner_.get() ? 22
20 sequenced_task_runner_->RunsTasksOnCurrentThread() : 23 if (!pool_)
darin (slow to review) 2013/07/02 13:54:23 this probably deserves a comment to draw attention
tommycli 2013/07/02 17:22:58 Done.
21 thread_checker_.CalledOnValidThread(); 24 return thread_checker_.CalledOnValidThread();
25
26 if (SequencedWorkerPool::Owner() != pool_)
27 return false;
28
29 return pool_->IsRunningSequenceOnCurrentThread(sequence_token_);
22 } 30 }
23 31
24 void SequenceCheckerImpl::ChangeSequence( 32 void SequenceCheckerImpl::DetachFromSequence() {
25 const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) {
26 AutoLock auto_lock(lock_); 33 AutoLock auto_lock(lock_);
27 sequenced_task_runner_ = sequenced_task_runner;
28 thread_checker_.DetachFromThread(); 34 thread_checker_.DetachFromThread();
35 sequence_token_assigned_ = false;
36 pool_ = NULL;
37 sequence_token_ = SequencedWorkerPool::SequenceToken();
38 }
39
40 void SequenceCheckerImpl::EnsureSequenceTokenAssigned() const {
41 AutoLock auto_lock(lock_);
42 if (sequence_token_assigned_)
43 return;
44
45 sequence_token_assigned_ = true;
46 pool_ = SequencedWorkerPool::Owner();
47
48 // If can't get sequence token, lock to the thread ID.
49 if (!pool_)
50 return;
51
52 bool got_token = pool_->GetCurrentThreadSequenceToken(&sequence_token_);
53 DCHECK(got_token);
29 } 54 }
30 55
31 } // namespace base 56 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698