Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1823083002: [stubs] Introduce AddStub and SubtractStub. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Introduce AddStub and SubtractStub. This adds two new stubs, AddStub and SubtractStub, for the plus and the minus operators, and hooks them up with TurboFan and Ignition. Especially the addition case is very heavy and we might want to look into splitting that up further into specialized stubs (similar to what we did with ToNumberStub recently). R=epertoso@chromium.org Committed: https://crrev.com/0bedf6f0614198d914d826e3a8def240fdf2bac8 Cr-Commit-Position: refs/heads/master@{#34994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+589 lines, -4 lines) Patch
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +534 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-22 13:40:01 UTC) #1
Benedikt Meurer
Hey Enrico, Here's Add and Subtract stubs for Ignition and TurboFan. Please take a look. ...
4 years, 9 months ago (2016-03-22 13:40:49 UTC) #2
epertoso
lgtm
4 years, 9 months ago (2016-03-22 15:04:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823083002/1
4 years, 9 months ago (2016-03-22 15:34:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 15:42:29 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 15:43:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bedf6f0614198d914d826e3a8def240fdf2bac8
Cr-Commit-Position: refs/heads/master@{#34994}

Powered by Google App Engine
This is Rietveld 408576698