DescriptionRevert of Exposed the children of elements with role textbox in order to make rich text information available… (patchset #4 id:60001 of https://codereview.chromium.org/1821723002/ )
Reason for revert:
Seeing if this patch is responsible for Win7 browser_tests timeouts that seem like they could be related, e.g. the following (note that the error output at least from my POV is not illuminating; the test then times out).
ContentSettingsExceptionAreaWebUITest.testOpenContentSettingsExceptionArea (run #1):
[ RUN ] ContentSettingsExceptionAreaWebUITest.testOpenContentSettingsExceptionArea
[1480:4536:0322/031442:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.
[4836:2768:0322/031445:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.
[1480:4536:0322/031446:ERROR:shell.cc(302)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
[3016:3588:0322/031447:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.
[1480:4536:0322/031448:ERROR:shell.cc(302)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
[2800:3724:0322/031450:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.
[1480:4536:0322/031453:WARNING:CONSOLE(0)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: (0)
[2800:3724:0322/031456:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
[1480:4536:0322/031458:INFO:CONSOLE(1180)] "Running TestCase ContentSettingsExceptionAreaWebUITest.MAYBE_testOpenContentSettingsExceptionArea", source: test_api.js (1180)
Example failing run:
https://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=47091
Will reland if this revert doesn't fix the problem.
Original issue's description:
> Exposed the children of elements with role textbox in order to make rich text information available to Windows screen readers.
>
> If we have an HTML element with role="textbox" we correctly assign it an IA role of ROLE_SYSTEM_TEXT. This is the same as what FireFox does.
> However, contrary to an <input> or <textarea> element, we should expose its children so that any rich text information would be available to Windows screen readers.
> Note that we also keep exposing a flatten representation of the children's text in the value attribute because Jaws and older versions of VoiceOver require it.
> BUG=542998
> TESTED:browser tests, Blink layout tests, manually with Jaws and NVDA with <input>, content editable and content editable with role="textbox"
> R=dmazzoni@chromium.org
>
> Committed: https://crrev.com/9a702688af0b856d52e96f1ce9b5346714ce8985
> Cr-Commit-Position: refs/heads/master@{#382526}
TBR=dmazzoni@chromium.org,nektar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=542998
Committed: https://crrev.com/bbe3ff03484cc92bb9d75dfe22989e1d1fa69ada
Cr-Commit-Position: refs/heads/master@{#382546}
Patch Set 1 #Messages
Total messages: 4 (2 generated)
|