Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1823053002: Revert of Exposed the children of elements with role textbox in order to make rich text information available… (Closed)

Created:
4 years, 9 months ago by blundell
Modified:
4 years, 9 months ago
Reviewers:
nektarios, dmazzoni
CC:
nektarios, aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Exposed the children of elements with role textbox in order to make rich text information available… (patchset #4 id:60001 of https://codereview.chromium.org/1821723002/ ) Reason for revert: Seeing if this patch is responsible for Win7 browser_tests timeouts that seem like they could be related, e.g. the following (note that the error output at least from my POV is not illuminating; the test then times out). ContentSettingsExceptionAreaWebUITest.testOpenContentSettingsExceptionArea (run #1): [ RUN ] ContentSettingsExceptionAreaWebUITest.testOpenContentSettingsExceptionArea [1480:4536:0322/031442:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled. [4836:2768:0322/031445:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled. [1480:4536:0322/031446:ERROR:shell.cc(302)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class. [3016:3588:0322/031447:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled. [1480:4536:0322/031448:ERROR:shell.cc(302)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class. [2800:3724:0322/031450:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled. [1480:4536:0322/031453:WARNING:CONSOLE(0)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: (0) [2800:3724:0322/031456:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! [1480:4536:0322/031458:INFO:CONSOLE(1180)] "Running TestCase ContentSettingsExceptionAreaWebUITest.MAYBE_testOpenContentSettingsExceptionArea", source: test_api.js (1180) Example failing run: https://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=47091 Will reland if this revert doesn't fix the problem. Original issue's description: > Exposed the children of elements with role textbox in order to make rich text information available to Windows screen readers. > > If we have an HTML element with role="textbox" we correctly assign it an IA role of ROLE_SYSTEM_TEXT. This is the same as what FireFox does. > However, contrary to an <input> or <textarea> element, we should expose its children so that any rich text information would be available to Windows screen readers. > Note that we also keep exposing a flatten representation of the children's text in the value attribute because Jaws and older versions of VoiceOver require it. > BUG=542998 > TESTED:browser tests, Blink layout tests, manually with Jaws and NVDA with <input>, content editable and content editable with role="textbox" > R=dmazzoni@chromium.org > > Committed: https://crrev.com/9a702688af0b856d52e96f1ce9b5346714ce8985 > Cr-Commit-Position: refs/heads/master@{#382526} TBR=dmazzoni@chromium.org,nektar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542998 Committed: https://crrev.com/bbe3ff03484cc92bb9d75dfe22989e1d1fa69ada Cr-Commit-Position: refs/heads/master@{#382546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -78 lines) Patch
M content/browser/accessibility/browser_accessibility.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -6 lines 0 comments Download
D content/test/data/accessibility/aria/aria-textbox-with-rich-text.html View 1 chunk +0 lines, -28 lines 0 comments Download
D content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-android.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-mac.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-win.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/is-richly-editable.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/is-richly-editable-expected.txt View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
blundell
Created Revert of Exposed the children of elements with role textbox in order to make ...
4 years, 9 months ago (2016-03-22 10:48:29 UTC) #1
blundell
4 years, 9 months ago (2016-03-22 12:09:42 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1826453002/ by blundell@chromium.org.

The reason for reverting is: Relanding
https://codereview.chromium.org/1821723002/ as the problematic bot went green
before this revert landed.

Powered by Google App Engine
This is Rietveld 408576698