[compiler] Move PassesFilter onto SharedFunctionInfo.

[compiler] Move PassesFilter onto SharedFunctionInfo.

The JSFunction::PassesFilter predicate is not fine-grained enough to
actually distinguish different closures and hence can be changed into
SharedFunctionInfo::PassesFilter instead. This will allow the compiler
to use is more broadly.

R=jkummerow@chromium.org

Committed: https://crrev.com/31d3c8a0749bde23f6a1013cc19e29e8dc292da0
Cr-Commit-Position: refs/heads/master@{#34981}

[Michael Starzinger, 2016-03-22 09:06:30]

mstarzinger@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Michael Starzinger, 2016-03-22 09:06:31]

Jakob: PTAL.
Ross: FYI.

https://codereview.chromium.org/1823033002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1823033002/diff/1/src/compiler.cc#newcode824
src/compiler.cc:824: return
info->closure()->shared()->PassesFilter(FLAG_ignition_filter);
Note that CompilationInfo::shared_info() cannot yet be used at this point. The
compilation pipeline is just not yet in shape for that, but the plan is to have
the SharedFunctionInfo available here as well.

https://codereview.chromium.org/1823033002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1823033002/diff/1/src/objects.cc#newcode13518
src/objects.cc:13518: String* name = DebugName();
The only change inside the function was this one line, the rest was just moved
to be in the same region with the other SFI methods.

[Jakob Kummerow, 2016-03-22 09:32:11]

LGTM!

https://codereview.chromium.org/1823033002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1823033002/diff/1/src/compiler.cc#newcode824
src/compiler.cc:824: return
info->closure()->shared()->PassesFilter(FLAG_ignition_filter);
On 2016/03/22 09:06:31, Michael Starzinger wrote:
> Note that CompilationInfo::shared_info() cannot yet be used at this point. The
> compilation pipeline is just not yet in shape for that, but the plan is to
have
> the SharedFunctionInfo available here as well.

Acknowledged.

https://codereview.chromium.org/1823033002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1823033002/diff/1/src/objects.cc#newcode13518
src/objects.cc:13518: String* name = DebugName();
On 2016/03/22 09:06:31, Michael Starzinger wrote:
> The only change inside the function was this one line, the rest was just moved
> to be in the same region with the other SFI methods.

Acknowledged.

[Michael Starzinger, 2016-03-22 09:58:57]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-03-22 09:59:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823033002/1

[commit-bot: I haz the power, 2016-03-22 10:01:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-22 10:02:22]

Description was changed from

==========
[compiler] Move PassesFilter onto SharedFunctionInfo.

The JSFunction::PassesFilter predicate is not fine-grained enough to
actually distinguish different closures and hence can be changed into
SharedFunctionInfo::PassesFilter instead. This will allow the compiler
to use is more broadly.

R=jkummerow@chromium.org
==========

to

==========
[compiler] Move PassesFilter onto SharedFunctionInfo.

The JSFunction::PassesFilter predicate is not fine-grained enough to
actually distinguish different closures and hence can be changed into
SharedFunctionInfo::PassesFilter instead. This will allow the compiler
to use is more broadly.

R=jkummerow@chromium.org

Committed: https://crrev.com/31d3c8a0749bde23f6a1013cc19e29e8dc292da0
Cr-Commit-Position: refs/heads/master@{#34981}
==========

[commit-bot: I haz the power, 2016-03-22 10:02:23]

Patchset 1 (id:??) landed as
https://crrev.com/31d3c8a0749bde23f6a1013cc19e29e8dc292da0
Cr-Commit-Position: refs/heads/master@{#34981}