Support external buffer import in VDA interface and add a V4L2SVDA impl.

content/common/gpu/media/v4l2_device.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the V4L2Device interface which is used by the
 // V4L2DecodeAccelerator class to delegate/pass the device specific
 // handling of any of the functionalities.
 
 #ifndef CONTENT_COMMON_GPU_MEDIA_V4L2_DEVICE_H_
 #define CONTENT_COMMON_GPU_MEDIA_V4L2_DEVICE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
+#include <linux/videodev2.h>
+
+#include "base/files/scoped_file.h"
 #include "base/memory/ref_counted.h"
 #include "content/common/content_export.h"
 #include "media/base/video_decoder_config.h"
 #include "media/base/video_frame.h"
 #include "media/video/video_decode_accelerator.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gl/gl_bindings.h"
 
 // TODO(posciak): remove this once V4L2 headers are updated.
 #define V4L2_PIX_FMT_VP9 v4l2_fourcc('V', 'P', '9', '0')
@@ skipping 54 matching lines @@
                      unsigned int len,
                      int prot,
                      int flags,
                      unsigned int offset) = 0;
   virtual void Munmap(void* addr, unsigned int len) = 0;
 
   // Initializes the V4L2Device to operate as a device of |type|.
   // Returns true on success.
   virtual bool Initialize() = 0;
 
+  // Return a vector of dmabuf file descriptors, exported for V4L2 buffer with
+  // |index|, assuming the buffer contains |num_planes| V4L2 planes and is of
+  // |type|. Return an empty vector on failure.
+  // The caller is responsible for closing the file descriptors after use.
+  virtual std::vector<base::ScopedFD> GetDmabufsForV4L2Buffer(
+      int index,
+      size_t num_planes,
+      enum v4l2_buf_type type) = 0;
+
   // Return true if the given V4L2 pixfmt can be used in CreateEGLImage()
   // for the current platform.
   virtual bool CanCreateEGLImageFrom(uint32_t v4l2_pixfmt) = 0;
 
-  // Creates an EGLImageKHR since each V4L2Device may use a different method of
-  // acquiring one and associating it to the given texture. The texture_id is
-  // used to bind the texture to the returned EGLImageKHR. buffer_index can be
-  // used to associate the returned EGLImageKHR by the underlying V4L2Device
-  // implementation.
-  virtual EGLImageKHR CreateEGLImage(EGLDisplay egl_display,
-                                     EGLContext egl_context,
-                                     GLuint texture_id,
-                                     gfx::Size frame_buffer_size,
-                                     unsigned int buffer_index,
-                                     uint32_t v4l2_pixfmt,
-                                     size_t num_v4l2_planes) = 0;
+  // Create an EGLImage from provided |dmabuf_fds| and bind |texture_id| to it.
+  // Some implementations may also require the V4L2 |buffer_index| of the buffer
+  // for which |dmabuf_fds| have been exported.

[kcwu, 2016/03/22 07:47:01]

Do we need to keep |dmabuf_fds| open after CreateEGLImage() return?

[Owen Lin, 2016/03/23 06:32:49]

How about using std::vector<base::ScopedFD> as the param's type, so it is clear
that CreateEGLImage will take the ownership? If the answer to kcwu's question is
"No".

[Pawel Osciak, 2016/03/28 01:31:28]

I intended to keep the option of retaining references to the fds for callers
that required it.

[Pawel Osciak, 2016/03/28 01:31:28]

No. Adding to the doc.

+  // Return EGL_NO_IMAGE_KHR on failure.
+  virtual EGLImageKHR CreateEGLImage(
+      EGLDisplay egl_display,
+      EGLContext /* egl_context */,

[kcwu, 2016/03/22 07:47:02]

remove /* */

[Pawel Osciak, 2016/03/28 01:31:28]

Done.

+      GLuint texture_id,
+      const gfx::Size& size,
+      unsigned int buffer_index,
+      uint32_t v4l2_pixfmt,
+      const std::vector<base::ScopedFD>& dmabuf_fds) = 0;
 
   // Destroys the EGLImageKHR.
   virtual EGLBoolean DestroyEGLImage(EGLDisplay egl_display,
                                      EGLImageKHR egl_image) = 0;
 
   // Returns the supported texture target for the V4L2Device.
   virtual GLenum GetTextureTarget() = 0;
 
   // Returns the preferred V4L2 input format or 0 if don't care.
   virtual uint32_t PreferredInputFormat() = 0;
@@ skipping 19 matching lines @@
   friend class base::RefCountedThreadSafe<V4L2Device>;
   explicit V4L2Device(Type type);
   virtual ~V4L2Device();
 
   const Type type_;
 };
 
 }  //  namespace content
 
 #endif  // CONTENT_COMMON_GPU_MEDIA_V4L2_DEVICE_H_