Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1822933002: vm-service: Include bytecode with _RegExp objects. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

vm-service: Include bytecode with _RegExp objects. BUG=http://dartbug.com/26042 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/1c107c4fbd8ff6b4aba858710039444975e79b6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M runtime/observatory/lib/src/elements/instance_view.html View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/object_service.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 9 months ago (2016-03-22 00:35:16 UTC) #3
Cutch
Sorry for the delay, I completely missed this one. LGTM
4 years, 8 months ago (2016-03-30 23:35:05 UTC) #4
rmacnak
4 years, 8 months ago (2016-03-31 17:05:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1c107c4fbd8ff6b4aba858710039444975e79b6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698