Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2724)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

Issue 1822913003: Handle the button presses in the password edit dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@password-edit-dialog.gitbr
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
index 75a1493fd2b2a0a58c07837e37dd4967d9e2f773..b87e0222f5c0aa5008ad75210285dd0f1b0669aa 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
@@ -24,25 +24,29 @@
<settings-dialog id="dialog">
<div class="title" i18n-content="editPasswordTitle"></div>
<div class="body">
- <paper-input i18n-values="label:editPasswordWebsiteLabel"
+ <paper-input id="websiteInput"
+ i18n-values="label:editPasswordWebsiteLabel"
value="[[item.loginPair.originUrl]]">
</paper-input>
- <paper-input i18n-values="label:editPasswordUsernameLabel"
+ <paper-input id="usernameInput"
+ i18n-values="label:editPasswordUsernameLabel"
value="[[item.loginPair.username]]">
</paper-input>
<div class="row">
- <paper-input i18n-values="label:editPasswordPasswordLabel"
- type="password"
- value="[[getEmptyPassword_(item.numCharactersInPassword)]]">
+ <paper-input id="passwordInput"
+ i18n-values="label:editPasswordPasswordLabel"
+ type="[[getPasswordInputType_(showPassword, password)]]"
+ value="[[getPassword_(showPassword, item, password)]]">
</paper-input>
- <!-- TODO(hcarmona): add on-tap -->
- <paper-icon-button icon="icons:visibility"></paper-icon-button>
+ <paper-icon-button id="showPasswordButton" icon="icons:visibility"
+ on-tap="onTapShowPasswordButton_"></paper-icon-button>
</div>
</div>
<div class="button-container">
- <!-- TODO(hcarmona): add on-tap for both buttons -->
- <paper-button i18n-content="cancel"></paper-button>
- <paper-button class="action-button" i18n-content="save"></paper-button>
+ <paper-button id="cancelButton" i18n-content="cancel"
+ on-tap="onTapCancelButton_"></paper-button>
+ <paper-button id="saveButton" class="action-button" i18n-content="save"
+ on-tap="onTapSaveButton_"></paper-button>
</div>
</settings-dialog>
</template>

Powered by Google App Engine
This is Rietveld 408576698