Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1822863002: - Properly return null if an unknown package is resolved. (Closed)

Created:
4 years, 9 months ago by Ivan Posva
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Properly return null if an unknown package is resolved. - Allow short form package:foo imports. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/3b2a695d71057f3a538f79f48a96f6bdca2474bb

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -25 lines) Patch
M runtime/bin/builtin.dart View 2 chunks +23 lines, -2 lines 1 comment Download
A tests/isolate/scenarios/bad_resolve_package/.packages View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/isolate/scenarios/bad_resolve_package/bad_resolve_package_test.dart View 1 1 chunk +8 lines, -23 lines 0 comments Download
A tests/isolate/scenarios/short_package/.packages View 1 chunk +1 line, -0 lines 0 comments Download
A tests/isolate/scenarios/short_package/flu_package/flu.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/isolate/scenarios/short_package/flu_package/flu.text View 1 chunk +1 line, -0 lines 0 comments Download
A tests/isolate/scenarios/short_package/short_package_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ivan Posva
4 years, 9 months ago (2016-03-21 23:09:22 UTC) #2
siva
lgtm https://codereview.chromium.org/1822863002/diff/1/tests/isolate/scenarios/bad_resolve_package/bad_resolve_package_test.dart File tests/isolate/scenarios/bad_resolve_package/bad_resolve_package_test.dart (right): https://codereview.chromium.org/1822863002/diff/1/tests/isolate/scenarios/bad_resolve_package/bad_resolve_package_test.dart#newcode23 tests/isolate/scenarios/bad_resolve_package/bad_resolve_package_test.dart:23: // Excpecting a null resolution for inexistent package ...
4 years, 9 months ago (2016-03-21 23:24:26 UTC) #3
Ivan Posva
Committed patchset #2 (id:20001) manually as 3b2a695d71057f3a538f79f48a96f6bdca2474bb (presubmit successful).
4 years, 9 months ago (2016-03-22 16:02:10 UTC) #5
Lasse Reichstein Nielsen
4 years, 9 months ago (2016-03-23 11:18:18 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1822863002/diff/20001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/1822863002/diff/20001/runtime/bin/builtin.dar...
runtime/bin/builtin.dart:305: path = "$packageName.dart";
While I like this change in general, it should be supported by all other
implementations as well, otherwise you can have code that works in the VM but
not in dart2js. Is that planned as well?

Otherwise, how about just resolving the path to "/"?

Powered by Google App Engine
This is Rietveld 408576698