Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/resources/settings/settings_dialog.js

Issue 1822813002: MD Settings: Make <settings-dialog> respond to ESC key. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ESC to Esc again. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-dialog' is a component for showing a modal dialog. 6 * @fileoverview 'settings-dialog' is a component for showing a modal dialog.
7 */ 7 */
8 Polymer({ 8 Polymer({
9 is: 'settings-dialog', 9 is: 'settings-dialog',
10 10
11 properties: { 11 properties: {
12 /** @override */ 12 /** @override */
13 modal: { 13 noCancelOnOutsideClick: {
14 type: Boolean, 14 type: Boolean,
15 value: true, 15 value: true,
16 }, 16 },
17
18 /** @override */
19 noCancelOnEscKey: {
20 type: Boolean,
21 value: false,
22 },
23
24 /** @override */
25 withBackdrop: {
26 type: Boolean,
27 value: true,
28 },
17 }, 29 },
18 30
19 behaviors: [Polymer.PaperDialogBehavior], 31 behaviors: [Polymer.PaperDialogBehavior],
20 32
21 /** @return {!PaperIconButtonElement} */ 33 /** @return {!PaperIconButtonElement} */
22 getCloseButton: function() { 34 getCloseButton: function() {
23 return this.$.close; 35 return this.$.close;
24 }, 36 },
25 }); 37 });
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698