Source/bindings/v8/V8WindowShell.cpp - Issue 18228003: Remove AtomicStringImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 18228003: Remove AtomicStringImpl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8WindowShell.cpp

diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp

index f46e3df87f63ed3c51915ce86fecefc1bb921a68..bb4e96503bbccc76dfa7bb4a0fc86bf997a3b5b3 100644

--- a/Source/bindings/v8/V8WindowShell.cpp

+++ b/Source/bindings/v8/V8WindowShell.cpp

@@ -449,7 +449,7 @@ static v8::Handle<v8::Value> getNamedProperty(HTMLDocument* htmlDocument, const

static void getter(v8::Local<v8::String> property, const v8::PropertyCallbackInfo<v8::Value>& info)

{

- // FIXME: Consider passing AtomicStringImpl directly.

+ // FIXME: Consider passing StringImpl directly.

AtomicString name = toWebCoreAtomicString(property);

HTMLDocument* htmlDocument = V8HTMLDocument::toNative(info.Holder());

ASSERT(htmlDocument);

« no previous file with comments | « no previous file | Source/core/css/CSSSelector.h » ('j') | Source/wtf/text/AtomicString.h » ('J')