Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 1822743002: Add host symlinks for microdump_stackwalk, minidump_* (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, sgurun-gerrit only
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add host symlinks for microdump_stackwalk, minidump_* It's not obvious how to build non-default-toolchain targets in ninja. Creating a wrapper alleviates the problem. BUG=none Committed: https://crrev.com/a218d2dade5114f1a0e8f8cebef14c47ae24f2ca Cr-Commit-Position: refs/heads/master@{#382611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -211 lines) Patch
M breakpad/BUILD.gn View 1 chunk +233 lines, -211 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
agrieve
4 years, 9 months ago (2016-03-21 17:53:32 UTC) #2
agrieve
On 2016/03/21 17:53:32, agrieve wrote: switching to mark since thestig is ooo
4 years, 9 months ago (2016-03-22 16:06:26 UTC) #5
Mark Mentovai
LGTM
4 years, 9 months ago (2016-03-22 16:20:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822743002/1
4 years, 9 months ago (2016-03-22 17:05:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 18:08:15 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 18:10:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a218d2dade5114f1a0e8f8cebef14c47ae24f2ca
Cr-Commit-Position: refs/heads/master@{#382611}

Powered by Google App Engine
This is Rietveld 408576698