Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1822673002: Make the findMetricsForCharacter SVGTextQuery-helper return an iterator (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-textquery--cleanup-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the findMetricsForCharacter SVGTextQuery-helper return an iterator Convert the helper to return an iterator into the metrics vector. Then use that new property in the calculateGlyphRange helper to avoid O(n^2) runtime. Also remove modifyStartEndPositionsRespectingLigatures, because all users of it (indirectly through mapStartEndPositionsIntoFragmentCoordinates) now uses the pre-computed text metrics - which should account for the same thing automatically. Also fix up the TODO in endPositionOfCharacterCallback by doing what it says. Committed: https://crrev.com/bd5d36e41e8ed061b646157465c91b4530b117d1 Cr-Commit-Position: refs/heads/master@{#382536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -59 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp View 7 chunks +21 lines, -59 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
fs
4 years, 9 months ago (2016-03-21 13:32:31 UTC) #3
pdr.
On 2016/03/21 at 13:32:31, fs wrote: > LGTM, so much cleaner
4 years, 9 months ago (2016-03-21 23:00:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822673002/1
4 years, 9 months ago (2016-03-22 08:45:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 09:12:04 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 09:13:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd5d36e41e8ed061b646157465c91b4530b117d1
Cr-Commit-Position: refs/heads/master@{#382536}

Powered by Google App Engine
This is Rietveld 408576698