Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1822573002: DevTools: adjust nexus 5x and 6p viewport sizes (Closed)

Created:
4 years, 9 months ago by paulirish
Modified:
4 years, 8 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: adjust nexus 5x and 6p viewport sizes BUG=591171 --- mccoy's patch landed these same changes, making mine moot. :) https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/devtools/+/a2dbf18dbfc0261e195471677ceb006544c823cd

Patch Set 1 #

Total comments: 1

Patch Set 2 : nexus 6p doesnt have insets so we only provide the effective size. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
paulirish
4 years, 9 months ago (2016-03-20 20:52:52 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1822573002/diff/1/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json File third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json (right): https://codereview.chromium.org/1822573002/diff/1/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json#newcode397 third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json:397: "height": 732 Perhaps, we can also set the ...
4 years, 9 months ago (2016-03-21 17:01:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822573002/20001
4 years, 8 months ago (2016-04-08 22:52:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/202380)
4 years, 8 months ago (2016-04-09 00:41:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822573002/20001
4 years, 8 months ago (2016-04-21 00:37:04 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 00:39:57 UTC) #12 
Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698