content/browser/service_worker/service_worker_register_job.cc - Issue 182253010: Register a Service Worker when an extension is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 182253010: Register a Service Worker when an extension is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Sync to r261176 Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index 1ed32a267eb6297dc4db84c21aed382a6c296994..cc881384f18ea9772b8293584be42073e9138079 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -144,6 +144,11 @@ void ServiceWorkerRegisterJob::StartWorkerAndContinue(

}

void ServiceWorkerRegisterJob::Complete(ServiceWorkerStatusCode status) {

+ if (status == SERVICE_WORKER_OK)

+ DCHECK(registration_);

+ else

+ registration_ = NULL;

for (std::vector<RegistrationCallback>::iterator it = callbacks_.begin();

it != callbacks_.end();

++it) {