Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: base/hash.h

Issue 182253007: base::Hash: Minor improvements to documentation and testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a comment that this algorithm is also in Blink. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/hash.cc » ('j') | base/hash_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/hash.h
diff --git a/base/hash.h b/base/hash.h
index 0b9c9f6bf0cf272d712d4de2458d215daa1808bb..e46f6ac24842d3ddb2d8263ae2a2f8f3c8164834 100644
--- a/base/hash.h
+++ b/base/hash.h
@@ -17,21 +17,20 @@ namespace base {
// WARNING: This hash function should not be used for any cryptographic purpose.
BASE_EXPORT uint32 SuperFastHash(const char* data, int len);
-// Computes the hash of a string |key| of a given |length|. |key| does not need
-// to be null-terminated, and may contain null bytes.
+// Computes a hash of a memory buffer |data| of a given |length|.
// WARNING: This hash function should not be used for any cryptographic purpose.
-inline uint32 Hash(const char* key, size_t length) {
+inline uint32 Hash(const char* data, size_t length) {
if (length > static_cast<size_t>(std::numeric_limits<int>::max())) {
NOTREACHED();
return 0;
}
- return SuperFastHash(key, static_cast<int>(length));
+ return SuperFastHash(data, static_cast<int>(length));
}
-// Computes the hash of a string |key|.
+// Computes a hash of a string |str|.
// WARNING: This hash function should not be used for any cryptographic purpose.
-inline uint32 Hash(const std::string& key) {
- return Hash(key.data(), key.size());
+inline uint32 Hash(const std::string& str) {
+ return Hash(str.data(), str.size());
}
} // namespace base
« no previous file with comments | « no previous file | base/hash.cc » ('j') | base/hash_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698