base::Hash: Minor improvements to documentation and testing.

base::Hash: Minor improvements to documentation and testing.

Renamed the char* argument to 'data' and the string argument to 'str'.
Cleaned up the comments on the char* overload (avoid using
string-specific terms and mentioning null byte). Mentioned that this
algorithm is also in Blink.

Added a test case testing that null bytes cause the hash to change.

BUG=347393
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255269

[Matt Giuca, 2014-03-05 04:31:23]

Making a few fixes to https://codereview.chromium.org/181643004/ as suggested by
Noel.

Brett: For OWNERS.

Thanks.

[Noel Gordon, 2014-03-05 04:47:00]

Thanks Matt, LGTM

https://codereview.chromium.org/182253007/diff/20001/base/hash_unittest.cc
File base/hash_unittest.cc (right):

https://codereview.chromium.org/182253007/diff/20001/base/hash_unittest.cc#ne...
base/hash_unittest.cc:28: // Add a null byte.
nit: maybe s/Add/Insert/ ?

[Matt Giuca, 2014-03-05 04:49:17]

https://codereview.chromium.org/182253007/diff/20001/base/hash_unittest.cc
File base/hash_unittest.cc (right):

https://codereview.chromium.org/182253007/diff/20001/base/hash_unittest.cc#ne...
base/hash_unittest.cc:28: // Add a null byte.
On 2014/03/05 04:47:01, Noel Gordon (Google) wrote:
> nit: maybe s/Add/Insert/ ?

Done.

[brettw, 2014-03-05 21:01:52]

lgtm

[Noel Gordon, 2014-03-05 22:00:03]

The CQ bit was checked by noel@chromium.org

[commit-bot: I haz the power, 2014-03-05 22:00:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/182253007/40001

[commit-bot: I haz the power, 2014-03-06 00:04:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/182253007/40001

[commit-bot: I haz the power, 2014-03-06 02:46:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/182253007/40001

[commit-bot: I haz the power, 2014-03-06 03:12:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/182253007/40001

[commit-bot: I haz the power, 2014-03-06 05:57:03]

Change committed as 255269

[Noel Gordon, 2014-03-06 06:31:59]

¯\(ツ)/¯

[Matt Giuca, 2014-03-06 07:42:15]

On 2014/03/06 06:31:59, Noel Gordon (Google) wrote:
> ¯\(ツ)/¯

+1