Remove desktop auto-login since we don't plan on shipping it.

Remove desktop auto-login since we don't plan on shipping it there.  Refactor the base and derived classes into one class since its android only now.

BUG=347214
TBR=pkasting@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258434

[Roger Tawa OOO till Jul 10th, 2014-03-02 02:46:07]

Hi Tommy.

Please take a look.  Thanks.

[nyquist, 2014-03-03 17:56:28]

This lgtm but adding miguelg since he knows this better than me. Please wait for
his review.

https://codereview.chromium.org/182253004/diff/180001/chrome/browser/ui/andro...
File chrome/browser/ui/android/infobars/auto_login_infobar_delegate.cc (left):

https://codereview.chromium.org/182253004/diff/180001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/auto_login_infobar_delegate.cc:217:
RecordHistogramAction(REJECTED);
Does this histogram go away now?

[Roger Tawa OOO till Jul 10th, 2014-03-04 20:32:33]

Thanks Tommy.

https://codereview.chromium.org/182253004/diff/180001/chrome/browser/ui/andro...
File chrome/browser/ui/android/infobars/auto_login_infobar_delegate.cc (left):

https://codereview.chromium.org/182253004/diff/180001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/auto_login_infobar_delegate.cc:217:
RecordHistogramAction(REJECTED);
On 2014/03/03 17:56:29, nyquist wrote:
> Does this histogram go away now?

Its possible this will no longer be recorded.  I'll take a look, but I think we
need to keep histogram definition so that we can continue ti see historical
data.  If not, I'll remove in a follow up CL.

[Miguel Garcia, 2014-03-05 12:46:56]

looks good, just want to make sure that this has been tested. What tests have
you performed?

Thanks

[Miguel Garcia, 2014-03-19 19:02:59]

lgtm

[Roger Tawa OOO till Jul 10th, 2014-03-19 19:21:16]

Hi Erik, Scott,

Can you please do an owner review:

Erik:
chrome/browser/resources/options/...
chrome/browser/ui/webui/options/browser_options_handler.cc

Scott:
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Thanks.

[sky, 2014-03-19 22:52:45]

LGTM

[James Hawkins, 2014-03-20 20:08:54]

lgtm

[Roger Tawa OOO till Jul 10th, 2014-03-20 20:10:51]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-03-20 20:12:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/182253004/290001

[commit-bot: I haz the power, 2014-03-20 22:15:50]

Change committed as 258434

[rohitrao (ping after 24h), 2014-03-21 21:53:32]

We still display the auto login infobar on iOS, so we were using the old code.

Since the code is used on two platforms, does it make sense to leave it in
c/b/ui?  Is there a better place for code that's shared between Android and iOS?

[rohitrao (ping after 24h), 2014-03-24 16:39:50]

I have reverted the original change (in
https://codereview.chromium.org/208393015/) to get the infobar code back for
iOS.

I will work on removing the feature from desktop only, while leaving the infobar
code in its current location.  Longer term, this code will likely move into a
component.