Issue 18225006: Fall back to generic on access checks in JSON.stringify.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18225006: Fall back to generic on access checks in JSON.stringify. (Closed)

Created:
7 years, 5 months ago by Yang

Modified:
7 years, 5 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -2 lines)			Patch
	M	src/json-stringifier.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		1 chunk	+72 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

lgtm, although I'd prefer to move the access checks before the switch if it doesn't ...

7 years, 5 months ago (2013-07-12 10:00:38 UTC) #2

Yang

7 years, 5 months ago (2013-07-12 10:04:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15641 (presubmit successful).