Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 18225: Experimental: processor flags are not preserved across CFG edges... (Closed)

Created:
11 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Experimental: processor flags are not preserved across CFG edges targeting labeled basic blocks. Merge code may be generated at the block exit which could potentially destroy a value in the flags register. This solution is to always materialize the flag result in a register. The generated code is known to be bad but (more) correct and will have to be fixed as a future change. Committed: http://code.google.com/p/v8/source/detail?r=1075

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -14 lines) Patch
M src/codegen-ia32.cc View 1 5 chunks +53 lines, -14 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Kevin Millikin (Chromium)
11 years, 11 months ago (2009-01-14 15:59:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698