Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1822423002: Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed. BUG=594120 R=jochen@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e432675850161570a8562f8c617da039f51f706d

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Test. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -15 lines) Patch
M fpdfsdk/jsapi/fxjs_v8.cpp View 1 2 chunks +6 lines, -7 lines 1 comment Download
M fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp View 1 2 2 chunks +66 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Jochen, for review.
4 years, 9 months ago (2016-03-23 20:32:00 UTC) #2
Tom Sepez
https://codereview.chromium.org/1822423002/diff/40001/fpdfsdk/jsapi/fxjs_v8.cpp File fpdfsdk/jsapi/fxjs_v8.cpp (right): https://codereview.chromium.org/1822423002/diff/40001/fpdfsdk/jsapi/fxjs_v8.cpp#newcode133 fpdfsdk/jsapi/fxjs_v8.cpp:133: v8::Local<v8::Object> obj = value.Get(isolate); Jochen: does this routine need ...
4 years, 9 months ago (2016-03-23 21:34:46 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-24 14:45:43 UTC) #5
Tom Sepez
4 years, 9 months ago (2016-03-24 16:13:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e432675850161570a8562f8c617da039f51f706d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698