include/core/SkSwizzle.h - Issue 1822363002: Publicly expose one accelerated swizzle.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: include/core/SkSwizzle.h

Issue 1822363002: Publicly expose one accelerated swizzle. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2016 Google Inc.

	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7

	8 #ifndef SkSwizzle_DEFINED

	9 #define SkSwizzle_DEFINED

	10

	11 /** Swizzles byte order of \|count\| 32-bit pixels. */

	12 void SkSwizzleRGBAToBGRA(uint32_t* src, void* dest, int count);
	mtklein 2016/03/23 17:02:34 Let's write (uint32_t* dest, const uint32_t* src, Let's write (uint32_t* dest, const uint32_t* src, int count). reed1 2016/03/23 17:03:23 // Swap the R and B bytes for each pixel/int32 Sh // Swap the R and B bytes for each pixel/int32 Should the name reflect the symmetric/agnostic nature of the swizzle? tomhudson 2016/03/23 17:25:50 Done. Show quoted text On 2016/03/23 17:02:34, mtklein wrote: > Let's write (uint32_t* dest, const uint32_t* src, int count). Done. tomhudson 2016/03/23 17:25:50 Done. Show quoted text On 2016/03/23 17:03:23, reed1 wrote: > // Swap the R and B bytes for each pixel/int32 > > Should the name reflect the symmetric/agnostic nature of the swizzle? Done.
	13

	14 #endif

OLD	NEW

« no previous file with comments | « no previous file | src/core/SkSwizzle.cpp » ('j') | src/core/SkSwizzle.cpp » ('J')