Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1822353002: Revert of wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h. (Closed)

Created:
4 years, 9 months ago by aberent
Modified:
4 years, 9 months ago
Reviewers:
haraken, Bret, Yuta Kitamura
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), gavinp+loader_chromium.org, Nate Chapin, jbroman, Justin Novosad, kinuko+watch, loading-reviews+fetch_chromium.org, Mikhail, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, sof, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h. (patchset #4 id:60001 of https://codereview.chromium.org/1814563002/ ) Reason for revert: Chrome crashes in power.typical_10_mobile test on various Android bots. BUG=597268 Original issue's description: > wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h. > > CheckedArithmetic was essentially the same functionality as safe_math > but had some edge cases it did not cover (e.g. size_t). Deleted the > CheckedArithmetic implementation and had it forward to safe_math, and > updated its callsites to use the latter's API. > > Committed: https://crrev.com/1465f844b54478a027711e86011a19214d8de24d > Cr-Commit-Position: refs/heads/master@{#382773} TBR=haraken@chromium.org,yutak@chromium.org,bsep@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/dc1e6dee244efea76741c796768707fa8d58afcb Cr-Commit-Position: refs/heads/master@{#382855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+901 lines, -73 lines) Patch
M third_party/WebKit/Source/core/dom/CharacterData.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.cpp View 3 chunks +12 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/wtf/CheckedArithmetic.h View 1 chunk +714 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/wtf/CheckedArithmeticTest.cpp View 1 chunk +150 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/wtf/CheckedNumeric.h View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/wtf/StdLibExtras.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
aberent
Created Revert of wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.
4 years, 9 months ago (2016-03-23 16:12:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822353002/1
4 years, 9 months ago (2016-03-23 16:12:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 16:13:09 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dc1e6dee244efea76741c796768707fa8d58afcb Cr-Commit-Position: refs/heads/master@{#382855}
4 years, 9 months ago (2016-03-23 16:15:10 UTC) #6
haraken
4 years, 9 months ago (2016-03-23 16:19:07 UTC) #7
Message was sent while issue was closed.
LGTM to revert.

Powered by Google App Engine
This is Rietveld 408576698