Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1822333002: Motown: wholesale clang-format (Closed)

Created:
4 years, 9 months ago by dalesat
Modified:
4 years, 9 months ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Un-maul BUILD.gn files. #

Patch Set 3 : dalesat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1623 lines, -2199 lines) Patch
M examples/media_test/keystroke.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/media_test/media_test.h View 2 chunks +4 lines, -6 lines 0 comments Download
M examples/media_test/media_test.cc View 5 chunks +14 lines, -19 lines 0 comments Download
M examples/media_test/media_test_app.cc View 9 chunks +43 lines, -45 lines 0 comments Download
M mojo/services/media/common/cpp/fifo_allocator.h View 1 chunk +17 lines, -19 lines 0 comments Download
M mojo/services/media/common/cpp/fifo_allocator.cc View 9 chunks +19 lines, -23 lines 0 comments Download
M mojo/services/media/common/cpp/mapped_shared_buffer.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/media/common/cpp/mapped_shared_buffer.cc View 3 chunks +6 lines, -10 lines 0 comments Download
M mojo/services/media/common/cpp/shared_media_buffer_allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/media/common/cpp/shared_media_buffer_allocator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/media/factory_service/audio_track_controller.h View 1 chunk +2 lines, -3 lines 0 comments Download
M services/media/factory_service/audio_track_controller.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M services/media/factory_service/event.h View 2 chunks +2 lines, -6 lines 0 comments Download
M services/media/factory_service/event.cc View 1 chunk +1 line, -3 lines 0 comments Download
M services/media/factory_service/factory_service.h View 2 chunks +19 lines, -26 lines 0 comments Download
M services/media/factory_service/factory_service.cc View 1 chunk +12 lines, -19 lines 0 comments Download
M services/media/factory_service/media_decoder_impl.h View 2 chunks +5 lines, -7 lines 0 comments Download
M services/media/factory_service/media_decoder_impl.cc View 3 chunks +8 lines, -13 lines 0 comments Download
M services/media/factory_service/media_player_impl.h View 5 chunks +16 lines, -21 lines 0 comments Download
M services/media/factory_service/media_player_impl.cc View 9 chunks +80 lines, -109 lines 0 comments Download
M services/media/factory_service/media_sink_impl.h View 3 chunks +9 lines, -12 lines 0 comments Download
M services/media/factory_service/media_sink_impl.cc View 11 chunks +83 lines, -104 lines 0 comments Download
M services/media/factory_service/media_source_impl.h View 4 chunks +18 lines, -23 lines 0 comments Download
M services/media/factory_service/media_source_impl.cc View 12 chunks +22 lines, -39 lines 0 comments Download
M services/media/factory_service/rule_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/media/factory_service/watched.h View 3 chunks +6 lines, -13 lines 0 comments Download
M services/media/framework/conversion_pipeline_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/conversion_pipeline_builder.cc View 10 chunks +34 lines, -53 lines 0 comments Download
M services/media/framework/engine.h View 1 chunk +14 lines, -17 lines 0 comments Download
M services/media/framework/engine.cc View 5 chunks +30 lines, -47 lines 0 comments Download
M services/media/framework/formatting.h View 3 chunks +12 lines, -16 lines 0 comments Download
M services/media/framework/formatting.cc View 9 chunks +72 lines, -73 lines 0 comments Download
M services/media/framework/graph.h View 4 chunks +15 lines, -14 lines 0 comments Download
M services/media/framework/graph.cc View 3 chunks +7 lines, -13 lines 0 comments Download
M services/media/framework/lpcm_util.h View 1 chunk +5 lines, -6 lines 0 comments Download
M services/media/framework/lpcm_util.cc View 5 chunks +37 lines, -44 lines 0 comments Download
M services/media/framework/metadata.h View 3 chunks +17 lines, -25 lines 0 comments Download
M services/media/framework/metadata.cc View 1 chunk +22 lines, -30 lines 0 comments Download
M services/media/framework/models/active_multistream_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/models/active_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/models/active_source.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/models/demand.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/models/multistream_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/media/framework/models/transform.h View 1 chunk +5 lines, -6 lines 0 comments Download
M services/media/framework/packet.h View 3 chunks +11 lines, -17 lines 0 comments Download
M services/media/framework/packet.cc View 2 chunks +26 lines, -47 lines 0 comments Download
M services/media/framework/parts/decoder.h View 2 chunks +3 lines, -4 lines 0 comments Download
M services/media/framework/parts/demux.h View 2 chunks +3 lines, -4 lines 0 comments Download
M services/media/framework/parts/file_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/parts/file_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/media/framework/parts/lpcm_reformatter.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/parts/lpcm_reformatter.cc View 10 chunks +39 lines, -65 lines 0 comments Download
M services/media/framework/parts/null_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/parts/null_sink.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/media/framework/parts/reader.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/parts/reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/media/framework/payload_allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/payload_allocator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/media/framework/refs.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M services/media/framework/result.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/safe_clone.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/media/framework/stages/active_multistream_sink_stage.h View 3 chunks +8 lines, -14 lines 0 comments Download
M services/media/framework/stages/active_multistream_sink_stage.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M services/media/framework/stages/active_sink_stage.h View 1 chunk +4 lines, -7 lines 0 comments Download
M services/media/framework/stages/active_sink_stage.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M services/media/framework/stages/active_source_stage.h View 1 chunk +5 lines, -10 lines 0 comments Download
M services/media/framework/stages/active_source_stage.cc View 4 chunks +12 lines, -16 lines 0 comments Download
M services/media/framework/stages/multistream_source_stage.h View 1 chunk +5 lines, -10 lines 0 comments Download
M services/media/framework/stages/multistream_source_stage.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M services/media/framework/stages/output.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M services/media/framework/stages/stage.h View 2 chunks +5 lines, -10 lines 0 comments Download
M services/media/framework/stages/stage.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M services/media/framework/stages/transform_stage.h View 1 chunk +5 lines, -10 lines 0 comments Download
M services/media/framework/stages/transform_stage.cc View 5 chunks +12 lines, -20 lines 0 comments Download
M services/media/framework/stream_type.h View 16 chunks +83 lines, -164 lines 0 comments Download
M services/media/framework/stream_type.cc View 10 chunks +108 lines, -140 lines 0 comments Download
M services/media/framework_create/decoder.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M services/media/framework_create/demux.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M services/media/framework_ffmpeg/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M services/media/framework_ffmpeg/av_codec_context.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework_ffmpeg/av_codec_context.cc View 8 chunks +17 lines, -28 lines 0 comments Download
M services/media/framework_ffmpeg/av_format_context.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework_ffmpeg/av_frame.h View 1 chunk +4 lines, -8 lines 0 comments Download
M services/media/framework_ffmpeg/av_io_context.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework_ffmpeg/av_io_context.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M services/media/framework_ffmpeg/av_packet.h View 2 chunks +3 lines, -5 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_audio_decoder.h View 4 chunks +15 lines, -19 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_audio_decoder.cc View 9 chunks +26 lines, -43 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_decoder.h View 1 chunk +3 lines, -4 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_decoder.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_decoder_base.h View 2 chunks +12 lines, -17 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_decoder_base.cc View 4 chunks +11 lines, -13 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_demux.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_demux.cc View 9 chunks +27 lines, -35 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_formatting.h View 2 chunks +29 lines, -30 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_formatting.cc View 33 chunks +89 lines, -86 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_init.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_init.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_video_decoder.h View 2 chunks +11 lines, -14 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_video_decoder.cc View 5 chunks +25 lines, -35 lines 0 comments Download
M services/media/framework_mojo/mojo_allocator.h View 2 chunks +3 lines, -4 lines 0 comments Download
M services/media/framework_mojo/mojo_consumer.h View 3 chunks +10 lines, -16 lines 0 comments Download
M services/media/framework_mojo/mojo_consumer.cc View 2 chunks +16 lines, -22 lines 0 comments Download
M services/media/framework_mojo/mojo_formatting.h View 2 chunks +26 lines, -39 lines 0 comments Download
M services/media/framework_mojo/mojo_formatting.cc View 21 chunks +118 lines, -121 lines 0 comments Download
M services/media/framework_mojo/mojo_producer.h View 3 chunks +5 lines, -8 lines 0 comments Download
M services/media/framework_mojo/mojo_producer.cc View 7 chunks +41 lines, -50 lines 0 comments Download
M services/media/framework_mojo/mojo_pull_mode_producer.h View 3 chunks +5 lines, -9 lines 0 comments Download
M services/media/framework_mojo/mojo_pull_mode_producer.cc View 6 chunks +13 lines, -16 lines 0 comments Download
M services/media/framework_mojo/mojo_type_conversions.h View 3 chunks +4 lines, -4 lines 0 comments Download
M services/media/framework_mojo/mojo_type_conversions.cc View 11 chunks +29 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dalesat
This is clang-formatting only...no other changes. Can I get a quick lgtm?
4 years, 9 months ago (2016-03-23 15:43:48 UTC) #2
kulakowski
lgtm
4 years, 9 months ago (2016-03-23 16:26:04 UTC) #3
dalesat
4 years, 9 months ago (2016-03-23 16:27:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
4ccdd21f9f96cef84eb70c2e46a3ff7586cdd719 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698