Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/ui/search/instant_page.h

Issue 18223002: InstantExtended: Remove overlay control code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_page.h
diff --git a/chrome/browser/ui/search/instant_page.h b/chrome/browser/ui/search/instant_page.h
index c11efe6de1f090d4c5517fb9938de8a7802e6a8d..db413cc4df4fae3eb2f37698ac9dbc2efed69ee7 100644
--- a/chrome/browser/ui/search/instant_page.h
+++ b/chrome/browser/ui/search/instant_page.h
@@ -33,8 +33,8 @@ class Rect;
// InstantPage is used to exchange messages with a page that implements the
// Instant/Embedded Search API (http://dev.chromium.org/embeddedsearch).
-// InstantPage is not used directly but via one of its derived classes:
-// InstantOverlay, InstantNTP and InstantTab.
+// InstantPage is not used directly but via one of its derived classes,
+// InstantNTP and InstantTab.
class InstantPage : public content::WebContentsObserver,
public SearchModelObserver {
public:
@@ -61,22 +61,6 @@ class InstantPage : public content::WebContentsObserver,
const content::WebContents* contents,
const GURL& url) = 0;
- // Called when the page has suggestions. Usually in response to Update(),
- // SendAutocompleteResults() or UpOrDownKeyPressed().
- virtual void SetSuggestions(
- const content::WebContents* contents,
- const std::vector<InstantSuggestion>& suggestions) = 0;
-
- // Called when the page wants to be shown. Usually in response to Update()
- // or SendAutocompleteResults().
- virtual void ShowInstantOverlay(const content::WebContents* contents,
- int height,
- InstantSizeUnits units) = 0;
-
- // Called when the page shows suggestions for logging purposes, regardless
- // of whether the page is processing the call.
- virtual void LogDropdownShown() = 0;
-
// Called when the page wants the omnibox to be focused. |state| specifies
// the omnibox focus state.
virtual void FocusOmnibox(const content::WebContents* contents,
@@ -151,8 +135,6 @@ class InstantPage : public content::WebContentsObserver,
virtual bool ShouldProcessRenderViewCreated();
virtual bool ShouldProcessRenderViewGone();
virtual bool ShouldProcessAboutToNavigateMainFrame();
- virtual bool ShouldProcessSetSuggestions();
- virtual bool ShouldProcessShowInstantOverlay();
virtual bool ShouldProcessFocusOmnibox();
virtual bool ShouldProcessNavigateToURL();
virtual bool ShouldProcessDeleteMostVisitedItem();
@@ -202,11 +184,6 @@ class InstantPage : public content::WebContentsObserver,
// Update the status of Instant support.
void InstantSupportDetermined(bool supports_instant);
- void OnSetSuggestions(int page_id,
- const std::vector<InstantSuggestion>& suggestions);
- void OnShowInstantOverlay(int page_id,
- int height,
- InstantSizeUnits units);
void OnFocusOmnibox(int page_id, OmniboxFocusState state);
void OnSearchBoxNavigate(int page_id,
const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698