|
|
Created:
4 years, 9 months ago by Michael Starzinger Modified:
4 years, 9 months ago Reviewers:
Michael Hablich CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[es6] Ship new ES6 instanceof operator semantics.
R=hablich@chromium.org
BUG=v8:4447
LOG=n
Committed: https://crrev.com/4560fe179f8240079e9b3ab539d4cb040d1d9b10
Cr-Commit-Position: refs/heads/master@{#35043}
Patch Set 1 #
Messages
Total messages: 21 (8 generated)
The CQ bit was checked by hablich@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822263003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822263003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822263003/1
On 2016/03/23 18:46:33, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1822263003/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1822263003/1 Changing test failures except the rebased ones ... Flake?
On 2016/03/23 18:49:34, Hablich wrote: > On 2016/03/23 18:46:33, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/patch-status/1822263003/1 > > View timeline at > > https://chromium-cq-status.appspot.com/patch-timeline/1822263003/1 > > Changing test failures except the rebased ones ... Flake? Doesn't look related at first glance. Let's try again.
On 2016/03/23 19:12:56, Michael Starzinger wrote: > On 2016/03/23 18:49:34, Hablich wrote: > > On 2016/03/23 18:46:33, commit-bot: I haz the power wrote: > > > CQ is trying da patch. Follow status at > > > https://chromium-cq-status.appspot.com/patch-status/1822263003/1 > > > View timeline at > > > https://chromium-cq-status.appspot.com/patch-timeline/1822263003/1 > > > > Changing test failures except the rebased ones ... Flake? > > Doesn't look related at first glance. Let's try again. Yeah. I would propose simply landing it if it does not work again. These tests are kinda flaky.
On 2016/03/23 19:15:26, Hablich wrote: > On 2016/03/23 19:12:56, Michael Starzinger wrote: > > On 2016/03/23 18:49:34, Hablich wrote: > > > On 2016/03/23 18:46:33, commit-bot: I haz the power wrote: > > > > CQ is trying da patch. Follow status at > > > > https://chromium-cq-status.appspot.com/patch-status/1822263003/1 > > > > View timeline at > > > > https://chromium-cq-status.appspot.com/patch-timeline/1822263003/1 > > > > > > Changing test failures except the rebased ones ... Flake? > > > > Doesn't look related at first glance. Let's try again. > > Yeah. I would propose simply landing it if it does not work again. These tests > are kinda flaky. Yep, fine with me as well, feel free to remove the try-bot include line from the description if the CQ happens to fail again.
Description was changed from ========== [es6] Ship new ES6 instanceof operator semantics. R=hablich@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel BUG=v8:4447 LOG=n ========== to ========== [es6] Ship new ES6 instanceof operator semantics. R=hablich@chromium.org BUG=v8:4447 LOG=n ==========
Message was sent while issue was closed.
Description was changed from ========== [es6] Ship new ES6 instanceof operator semantics. R=hablich@chromium.org BUG=v8:4447 LOG=n ========== to ========== [es6] Ship new ES6 instanceof operator semantics. R=hablich@chromium.org BUG=v8:4447 LOG=n ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [es6] Ship new ES6 instanceof operator semantics. R=hablich@chromium.org BUG=v8:4447 LOG=n ========== to ========== [es6] Ship new ES6 instanceof operator semantics. R=hablich@chromium.org BUG=v8:4447 LOG=n Committed: https://crrev.com/4560fe179f8240079e9b3ab539d4cb040d1d9b10 Cr-Commit-Position: refs/heads/master@{#35043} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4560fe179f8240079e9b3ab539d4cb040d1d9b10 Cr-Commit-Position: refs/heads/master@{#35043} |