Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1822263002: Fix DCHECK failure on bots when registry key can't be opened successfully. (Closed)

Created:
4 years, 9 months ago by Peter Kasting
Modified:
4 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK failure on bots when registry key can't be opened successfully. I don't know why this happens, but we should have this sanity check anyway. BUG=592676 TEST=none TBR=estade Committed: https://crrev.com/6d73369e32f4cb2dbeec4d8080c377f545ff8640 Cr-Commit-Position: refs/heads/master@{#382825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/themes/theme_service_win.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Peter Kasting
TBRing since apparently various bots are red
4 years, 9 months ago (2016-03-23 10:20:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822263002/1
4 years, 9 months ago (2016-03-23 10:21:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 10:55:15 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d73369e32f4cb2dbeec4d8080c377f545ff8640 Cr-Commit-Position: refs/heads/master@{#382825}
4 years, 9 months ago (2016-03-23 10:56:15 UTC) #9
Evan Stade
4 years, 9 months ago (2016-03-23 18:31:38 UTC) #10
Message was sent while issue was closed.
On 2016/03/23 10:56:15, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/6d73369e32f4cb2dbeec4d8080c377f545ff8640
> Cr-Commit-Position: refs/heads/master@{#382825}

rs lgtm

Powered by Google App Engine
This is Rietveld 408576698