Issue 1822233002: Handle the case where a single-line comment is less than 3 characters long.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1822233002: Handle the case where a single-line comment is less than 3 characters long. (Closed)

Created:
4 years, 9 months ago by azani

Modified:
4 years, 9 months ago

Reviewers:
rudominer

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Handle the case where a single-line comment is less than 3 characters long. R=rudominer@chromium.org, rudominer BUG= #592 Committed: https://chromium.googlesource.com/external/mojo/+/3c4bd1a984abc35562e3894f52b6b052eab9bdb6

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -4 lines)			Patch
M	mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojom/mojom_parser/formatter/printer.go	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

azani

4 years, 9 months ago (2016-03-23 17:27:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3c4bd1a984abc35562e3894f52b6b052eab9bdb6 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages