Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: content/public/test/test_launcher.h

Issue 1822213002: Changes to get mash browser_tests shutdown working correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/mojo_shell_connection.h ('k') | content/public/test/test_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_launcher.h
diff --git a/content/public/test/test_launcher.h b/content/public/test/test_launcher.h
index 117c65866ba967afb9489b7d9a96eeb07be93a04..b6a9f7063ec0453493196e0f251ca46eee258614 100644
--- a/content/public/test/test_launcher.h
+++ b/content/public/test/test_launcher.h
@@ -50,6 +50,11 @@ class TestLauncherDelegate {
virtual void PostRunMessageLoop() {}
virtual ContentMainDelegate* CreateContentMainDelegate() = 0;
+ // Called prior to returning from LaunchTests(). Gives the delegate a chance
+ // to do cleanup before state created by TestLauncher has been destroyed (such
+ // as the AtExitManager).
+ virtual void OnDoneRunningTests();
jam 2016/03/23 15:12:16 nit: move this to the end (after line 70) so that
+
// Called prior to running each test. The delegate may alter the CommandLine
// and options used to launch the subprocess. Additionally the client may
// return a TestState that is destroyed once the test completes as well as
« no previous file with comments | « content/public/common/mojo_shell_connection.h ('k') | content/public/test/test_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698