Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1822213002: Changes to get mash browser_tests shutdown working correctly (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes to get mash browser_tests shutdown working correctly . Adds ability to set callback on MojoShellConnection when shell is lost, and wires through in chrome side to trigger exiting. . Adds ability for TestLauncherDelegate to be notified after tests have run. Needed so I can shutdown state while AtExitManager is valid. . Made context not attempt to shutdown edk if context did not start edk. . Made MashBrowserTestsMain shutdown MojoTestConnector at a time when it can be shutdown. BUG=581733 TEST=covered by tests R=jam@chromium.org Committed: https://crrev.com/220db613792b3fa65361e478ddd00da753e7aa7c Cr-Commit-Position: refs/heads/master@{#382864}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 1

Patch Set 3 : order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -15 lines) Patch
M chrome/browser/chrome_browser_main.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 4 chunks +52 lines, -12 lines 0 comments Download
M chrome/test/base/mojo_test_connector.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/test/test_launcher.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/test/test_launcher.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M mojo/shell/standalone/context.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/standalone/context.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 9 months ago (2016-03-22 23:18:44 UTC) #1
jam
lgtm https://codereview.chromium.org/1822213002/diff/20001/content/public/test/test_launcher.h File content/public/test/test_launcher.h (right): https://codereview.chromium.org/1822213002/diff/20001/content/public/test/test_launcher.h#newcode56 content/public/test/test_launcher.h:56: virtual void OnDoneRunningTests(); nit: move this to the ...
4 years, 9 months ago (2016-03-23 15:12:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822213002/40001
4 years, 9 months ago (2016-03-23 15:36:42 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-23 16:39:03 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 16:40:20 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/220db613792b3fa65361e478ddd00da753e7aa7c
Cr-Commit-Position: refs/heads/master@{#382864}

Powered by Google App Engine
This is Rietveld 408576698