media/blink/webmediaplayer_impl.cc - Issue 1822153002: Attempt at suspend fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1822153002: Attempt at suspend fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/webmediaplayer_impl.cc

diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc

index bbab083d55dd21aa663bffe248390c0092b43b83..6aa487655f3d1a112b149d380ccc1df5dfc4868e 100644

--- a/media/blink/webmediaplayer_impl.cc

+++ b/media/blink/webmediaplayer_impl.cc

@@ -1121,7 +1121,8 @@ void WebMediaPlayerImpl::OnSuspendRequested(bool must_suspend) {

return;

#endif

-#if defined(OS_MACOSX)

+ printf("OnSuspendRequest\n");

+#if 0

// TODO(sandersd): Idle suspend is disabled on OSX since hardware decoded

// frames are owned by the video decoder in the GPU process. A mechanism for

// detaching ownership from the decoder is needed. http://crbug.com/595716.