Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1822133002: Converts mash_wm_apptests to unit tests (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts mash_wm_apptests to unit tests BUG=594733 TEST=test only change R=dpranke@chromium.org, erg@chromium.org Committed: https://crrev.com/48ad0960ce059aa1c17c6acdcda49d67419c8ccd Cr-Commit-Position: refs/heads/master@{#382652}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -255 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/BUILD.gn View 3 chunks +13 lines, -11 lines 0 comments Download
A mash/unittests_manifest.json View 1 1 chunk +5 lines, -0 lines 0 comments Download
M mash/wm/BUILD.gn View 3 chunks +4 lines, -45 lines 0 comments Download
D mash/wm/accelerator_registrar_apptest.cc View 1 chunk +0 lines, -114 lines 0 comments Download
A + mash/wm/accelerator_registrar_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D mash/wm/apptest_manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
D mash/wm/window_manager_apptest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
A + mash/wm/window_manager_unittest.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M mojo/tools/data/apptests View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sky
Dirk for BUILD.gn, Elliot for the rest.
4 years, 9 months ago (2016-03-22 18:24:27 UTC) #1
Elliot Glaysher
lgtm
4 years, 9 months ago (2016-03-22 18:26:36 UTC) #2
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-22 18:30:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822133002/20001
4 years, 9 months ago (2016-03-22 19:08:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 19:46:09 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 19:47:49 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/48ad0960ce059aa1c17c6acdcda49d67419c8ccd
Cr-Commit-Position: refs/heads/master@{#382652}

Powered by Google App Engine
This is Rietveld 408576698