Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 182213005: Move api_resource{,manager} out of src/chrome (Closed)

Created:
6 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 9 months ago
Reviewers:
James Cook
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move api_resource{,manager} out of src/chrome This is a mechanical change. No new DEPS are introduced into src/extensions. clang_format was also applied to all touched extensions code, for great justice. BUG=349930 TBR=wez@chromium.org,yoz@chromium.org,rpaquay@chromium.org,erg@chromium.org for mechanical changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255575

Patch Set 1 #

Total comments: 2

Patch Set 2 : add todo #

Patch Set 3 : undo some formatting #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -719 lines) Patch
D chrome/browser/extensions/api/api_resource.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/extensions/api/api_resource.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/extensions/api/api_resource_manager.h View 1 chunk +0 lines, -333 lines 0 comments Download
M chrome/browser/extensions/api/api_resource_manager_unittest.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_channel_api.h View 4 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_socket.h View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/hid/hid_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/hid/hid_api.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/hid/hid_connection_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/serial/serial_connection.h View 4 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_connection.cc View 7 chunks +10 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_event_dispatcher.h View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket.h View 5 chunks +13 lines, -17 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket.cc View 5 chunks +15 lines, -19 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_api.h View 5 chunks +16 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_api_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/socket/tcp_socket.cc View 15 chunks +32 lines, -43 lines 0 comments Download
M chrome/browser/extensions/api/socket/udp_socket.cc View 12 chunks +26 lines, -42 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/tcp_socket_event_dispatcher.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/sockets_udp/sockets_udp_api_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/sockets_udp/udp_socket_event_dispatcher.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.h View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_device_resource.h View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_device_resource.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
A + extensions/browser/api/api_resource.h View 3 chunks +4 lines, -6 lines 0 comments Download
A + extensions/browser/api/api_resource.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + extensions/browser/api/api_resource_manager.h View 13 chunks +37 lines, -44 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Cook
LGTM I generally don't reformat entire files with clang-format, just the lines I touch. But ...
6 years, 9 months ago (2014-03-06 19:29:25 UTC) #1
Ken Rockot(use gerrit already)
I'll take all the blame, sure. I had a brief conversation with scheib@ about formatting ...
6 years, 9 months ago (2014-03-06 19:47:24 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-06 23:23:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/182213005/80001
6 years, 9 months ago (2014-03-06 23:33:01 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 10:17:31 UTC) #5
Message was sent while issue was closed.
Change committed as 255575

Powered by Google App Engine
This is Rietveld 408576698