Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 182213003: Add new PPB_OPENGLES2_DRAWBUFFERS_DEV_INTERFACE_1_0 pepper interface. (Closed)

Created:
6 years, 10 months ago by jbauman
Modified:
6 years, 9 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, raymes+watch_chromium.org, teravest+watch_chromium.org, yzshen+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org, teravest
Visibility:
Public.

Description

Add new PPB_OPENGLES2_DRAWBUFFERS_DEV_INTERFACE_1_0 pepper interface. This allows applications to draw to multiple render targets at the same time. BUG=318019 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255222

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1 line) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/c/dev/ppb_opengles2ext_dev.h View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M ppapi/lib/gl/gles2/gl2ext_ppapi.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/lib/gl/gles2/gl2ext_ppapi.c View 1 3 chunks +11 lines, -0 lines 0 comments Download
M ppapi/lib/gl/gles2/gles2.c View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppb_opengles2_shared.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_opengles2_shared.cc View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M ppapi/thunk/interfaces_legacy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
jbauman
6 years, 10 months ago (2014-02-27 01:06:36 UTC) #1
dmichael (off chromium)
lgtm, but... If we expect to do more OpenGL extensions as "Dev" over time, we ...
6 years, 9 months ago (2014-03-04 16:57:15 UTC) #2
dmichael (off chromium)
Oops, missed one important thing. Please fix the permission before landing. https://codereview.chromium.org/182213003/diff/20001/ppapi/proxy/interface_list.cc File ppapi/proxy/interface_list.cc (right): ...
6 years, 9 months ago (2014-03-04 17:00:17 UTC) #3
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 9 months ago (2014-03-04 19:27:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/182213003/30001
6 years, 9 months ago (2014-03-04 19:32:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 20:04:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53387
6 years, 9 months ago (2014-03-04 20:04:26 UTC) #7
jbauman
I guess I also need an OWNERS review for the histogram addition.
6 years, 9 months ago (2014-03-04 20:17:18 UTC) #8
Ilya Sherman
histograms.xml lgtm
6 years, 9 months ago (2014-03-04 22:44:10 UTC) #9
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 9 months ago (2014-03-04 22:44:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/182213003/50001
6 years, 9 months ago (2014-03-04 22:44:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/182213003/50001
6 years, 9 months ago (2014-03-05 01:09:04 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 01:09:09 UTC) #13
commit-bot: I haz the power
Failed to apply patch for ppapi/c/dev/ppb_opengles2ext_dev.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-05 01:09:09 UTC) #14
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 9 months ago (2014-03-05 21:17:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/182213003/70001
6 years, 9 months ago (2014-03-05 21:19:49 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 22:59:05 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275601
6 years, 9 months ago (2014-03-05 22:59:05 UTC) #18
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 9 months ago (2014-03-05 23:25:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/182213003/70001
6 years, 9 months ago (2014-03-05 23:28:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/182213003/70001
6 years, 9 months ago (2014-03-06 00:10:28 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 02:11:21 UTC) #22
Message was sent while issue was closed.
Change committed as 255222

Powered by Google App Engine
This is Rietveld 408576698