Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1822083003: Add is_open property to NetworkController (Closed)

Created:
4 years, 9 months ago by gurrrik
Modified:
4 years, 9 months ago
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add is_open property to NetworkController This adds the ability to check the status of network_controller without directly accessing its protected member. BUG=catapult:#2179 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e1c202aed5868e0a5ecdbb1710b0699b302068f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M telemetry/telemetry/core/network_controller.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
gurrrik
On 2016/03/23 15:06:35, gurrrik wrote: > mailto:gurrrik@yandex-team.ru changed reviewers: > + mailto:nednguyen@google.com I want to ...
4 years, 9 months ago (2016-03-23 15:26:32 UTC) #3
aiolos (Not reviewing)
Could you please open a bug for the issue and add it to the description? ...
4 years, 9 months ago (2016-03-24 00:24:16 UTC) #5
gurrrik
On 2016/03/24 00:24:16, aiolos wrote: > Could you please open a bug for the issue ...
4 years, 9 months ago (2016-03-25 09:21:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822083003/1
4 years, 9 months ago (2016-03-25 09:23:40 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 09:36:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698