Do not close network controller in ProfileExtender if it was not opened there.

Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG=597923
Committed: https://crrev.com/636566857c10b4a4039de0656e5a289f6b775a04
Cr-Commit-Position: refs/heads/master@{#383487}

[gurrrik, 2016-03-23 15:25:31]

Description was changed from

==========
Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG=
==========

to

==========
Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG=
==========

[gurrrik, 2016-03-23 15:25:31]

gurrrik@yandex-team.ru changed reviewers:
+ aiolos@chromium.org

[aiolos (Not reviewing), 2016-03-24 00:25:24]

Could you also file a bug and update the cl description with it?

[gurrrik, 2016-03-25 08:59:07]

Description was changed from

==========
Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG=
==========

to

==========
Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG=597923
==========

[gurrrik, 2016-03-25 09:23:58]

On 2016/03/24 00:25:24, aiolos wrote:
> Could you also file a bug and update the cl description with it?

Sure, done.

[gurrrik, 2016-03-25 10:01:25]

The CL for catapult was committed, so I updated this CL to remove protected
member access.

[aiolos (Not reviewing), 2016-03-25 18:38:14]

Catapult should autoroll into chromium, so no need to change the deps. (You may
accidentally undo a roll to a more recent version of catapult if you land
as-is.) Just make sure that catapult has already rolled.

lgtm without the DEPS change.

[gurrrik, 2016-03-28 09:03:43]

On 2016/03/25 18:38:14, aiolos wrote:
> Catapult should autoroll into chromium, so no need to change the deps. (You
may
> accidentally undo a roll to a more recent version of catapult if you land
> as-is.) Just make sure that catapult has already rolled.
> 
> lgtm without the DEPS change.

Thank you for clarification! I've reverted the DEPS change.

[gurrrik, 2016-03-28 09:04:07]

The CQ bit was checked by gurrrik@yandex-team.ru

[gurrrik, 2016-03-28 09:04:07]

The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org
Link to the patchset: https://codereview.chromium.org/1822043004/#ps40001
(title: "Rebase changes")

[commit-bot: I haz the power, 2016-03-28 09:04:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822043004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822043004/40001

[commit-bot: I haz the power, 2016-03-28 10:25:41]

Description was changed from

==========
Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG=597923
==========

to

==========
Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG=597923
==========

[commit-bot: I haz the power, 2016-03-28 10:25:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-28 10:27:35]

Description was changed from

==========
Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG=597923
==========

to

==========
Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG=597923

Committed: https://crrev.com/636566857c10b4a4039de0656e5a289f6b775a04
Cr-Commit-Position: refs/heads/master@{#383487}
==========

[commit-bot: I haz the power, 2016-03-28 10:27:36]

Patchset 3 (id:??) landed as
https://crrev.com/636566857c10b4a4039de0656e5a289f6b775a04
Cr-Commit-Position: refs/heads/master@{#383487}