Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18219003: Simplify and unify PolymorphicStoreNameFeild (Closed)

Created:
7 years, 5 months ago by danno
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Simplify and unify PolymorphicStoreNameFeild R=verwaest@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix stuff #

Patch Set 3 : More tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -329 lines) Patch
M src/apinatives.js View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 5 chunks +12 lines, -8 lines 0 comments Download
M src/hydrogen.h View 1 2 9 chunks +63 lines, -26 lines 0 comments Download
M src/hydrogen.cc View 1 2 55 chunks +128 lines, -186 lines 0 comments Download
M src/hydrogen-deoptimizing-mark.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-environment-liveness.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/hydrogen-gvn.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 2 5 chunks +12 lines, -58 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/hydrogen-osr.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
danno
7 years, 5 months ago (2013-07-08 16:08:14 UTC) #1
Toon Verwaest
7 years, 5 months ago (2013-07-08 16:49:00 UTC) #2 
https://codereview.chromium.org/18219003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/18219003/diff/1/src/hydrogen.cc#newcode5797
src/hydrogen.cc:5797: (current_type == types->length() - 1)) {
remove the - 1

https://codereview.chromium.org/18219003/diff/1/src/hydrogen.cc#newcode5799
src/hydrogen.cc:5799: AddSoftDeoptimize(MUST_EMIT_SOFT_DEOPT);
Soft deopts aren't counted towards MaxDeopt to stop attempting to optimize. We
should use a hard deopt instead.

Powered by Google App Engine
This is Rietveld 408576698